From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangfei Subject: Re: [PATCH v2 1/3] i2c: hix5hd2: add devicetree documentation Date: Tue, 30 Sep 2014 17:25:25 +0800 Message-ID: <542A7705.2030404@linaro.org> References: <1411878129-19743-1-git-send-email-zhangfei.gao@linaro.org> <1411878129-19743-2-git-send-email-zhangfei.gao@linaro.org> <2135291.ciFUCkAm4U@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2135291.ciFUCkAm4U@wuerfel> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Wolfram Sang , haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wei Yan List-Id: devicetree@vger.kernel.org On 09/30/2014 05:01 PM, Arnd Bergmann wrote: > On Sunday 28 September 2014 12:22:07 Zhangfei Gao wrote: >> + >> +Required properties: >> +- compatible: Must be "hisilicon,hix5hd2-i2c" >> + Specifically, the following versions of the chipset are supported: >> + Hi3716CV200 (support six I2C module) >> + Hi3719CV100 (support six I2C module) >> + Hi3718CV100 (support six I2C module) >> + Hi3719MV100 (support two I2C module) >> + Hi3718MV100 (support two I2C module) >> > > How do you detect the specific model? Is there a hardware register that > lets you know the type? > If you have a device specific "compatible" string, you should list all > the known strings. > In fact, no need to distinguish these hardware, the only difference is i2c module number. The same compatible is used. These info can be removed to remove the confusion. Thanks