From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2] thermal: Add QPNP PMIC temperature alarm driver Date: Tue, 30 Sep 2014 12:46:18 -0700 Message-ID: <542B088A.1050601@codeaurora.org> References: <1411651825-14240-1-git-send-email-iivanov@mm-sol.com> <54254C4E.3070807@smartplayin.com> <1411998865.5395.5.camel@iivanov-dev> <542A31DF.7020402@smartplayin.com> <1412062606.5395.10.camel@iivanov-dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1412062606.5395.10.camel@iivanov-dev> Sender: linux-pm-owner@vger.kernel.org To: "Ivan T. Ivanov" , Kiran Padwal Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, David Collins List-Id: devicetree@vger.kernel.org On 09/30/14 00:36, Ivan T. Ivanov wrote: > On Tue, 2014-09-30 at 10:00 +0530, Kiran Padwal wrote: >> >> I have Linaro cross tool chain with version-4.8.3 and I am simply doing "make zImage" without any option. > Hm, no warnings with arm-unknown-linux-gnueabi-gcc (GCC) 4.6.3 and > arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-4.9-2014.09, but > indeed arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-4.8-2014.03. > > I will say that this is false positive :-). Please update your tool-chain. Hopefully you're joking. Once this merges someone will find the warning and complain. Telling them to upgrade their compiler isn't going to work. I wonder if checking for rc != 0 instead of rc < 0 would silence the warning? Or get rid of the entire wrapper function and just use regmap functions directly. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation