[PATCH v2 0/2] arm: shimobile: add HS-USB device node on r8a7790

[PATCH v2 0/2] arm: shimobile: add HS-USB device node on r8a7790

[Yoshihiro Shimoda]

 This series is based on Simon's renesas.git branch and
renesas-devel-20141007-v3.17 tag. If we use the generic phy
driver for R-Car Gen2 (drivers/phy/phy-rcar-gen2.c), we can use
the HS-USB on lager.

Changes from v1:
 - Correct typo of git log in patch 1.
 - Change the placement of hsusb node in patch 1.
 - Add git log comment in patch 2.
 - Fix the gpio prop in patch 2.

Yoshihiro Shimoda (2):
  arm: shmobile: r8a7790: add HS-USB device node
  arm: shmobile: lager: enable HS-USB

 arch/arm/boot/dts/r8a7790-lager.dts |    5 +++++
 arch/arm/boot/dts/r8a7790.dtsi      |   11 +++++++++++
 2 files changed, 16 insertions(+)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/2] arm: shmobile: r8a7790: add HS-USB device node

[Yoshihiro Shimoda]

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm/boot/dts/r8a7790.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 2380fd5..63a75f2 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -600,6 +600,17 @@
 		status = "disabled";
 	};
 
+	hsusb: usb@e6590000 {
+		compatible = "renesas,usbhs-r8a7790";
+		reg = <0 0xe6590000 0 0x100>;
+		interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
+		renesas,buswait = <4>;
+		phys = <&usb0 1>;
+		phy-names = "usb";
+		status = "disabled";
+	};
+
 	usbphy: usb-phy@e6590100 {
 		compatible = "renesas,usb-phy-r8a7790";
 		reg = <0 0xe6590100 0 0x100>;
-- 
1.7.9.5

[PATCH v2 2/2] arm: shmobile: lager: enable HS-USB

[Yoshihiro Shimoda]

Since this board doesn't have USB ID pin, we assumes the GP5_18 (USB0_PWEN)
is an ID pin because the gpio is high when the SW5 is Pin 3 side.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
 arch/arm/boot/dts/r8a7790-lager.dts |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 719979e..011254a 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -446,3 +446,8 @@
 		};
 	};
 };
+
+&hsusb {
+	status = "okay";
+	renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_HIGH>;
+};
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] arm: shmobile: lager: enable HS-USB

[Sergei Shtylyov]

On 10/7/2014 3:10 PM, Yoshihiro Shimoda wrote:

> Since this board doesn't have USB ID pin, we assumes the GP5_18 (USB0_PWEN)
> is an ID pin because the gpio is high when the SW5 is Pin 3 side.

> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>   arch/arm/boot/dts/r8a7790-lager.dts |    5 +++++
>   1 file changed, 5 insertions(+)

> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 719979e..011254a 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -446,3 +446,8 @@
>   		};
>   	};
>   };
> +
> +&hsusb {
> +	status = "okay";
> +	renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_HIGH>;
> +};

    As I said before, this is not enough. We need pinctrl-related props. Same 
is true for other boards.

WBR, Sergei

Re: [PATCH v2 2/2] arm: shmobile: lager: enable HS-USB

[Yoshihiro Shimoda]

(2014/10/07 20:42), Sergei Shtylyov wrote:
> On 10/7/2014 3:10 PM, Yoshihiro Shimoda wrote:
> 
>> Since this board doesn't have USB ID pin, we assumes the GP5_18 (USB0_PWEN)
>> is an ID pin because the gpio is high when the SW5 is Pin 3 side.
> 
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>>   arch/arm/boot/dts/r8a7790-lager.dts |    5 +++++
>>   1 file changed, 5 insertions(+)
> 
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>> index 719979e..011254a 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -446,3 +446,8 @@
>>           };
>>       };
>>   };
>> +
>> +&hsusb {
>> +    status = "okay";
>> +    renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_HIGH>;
>> +};
> 
>    As I said before, this is not enough. We need pinctrl-related props. Same is true for other boards.

Thank you very much for the point again.
Finally I understood what you said before.
I will start studying the pinctrl world.

Best regards,
Yoshihiro Shimoda

> WBR, Sergei
> 

Re: [PATCH v2 2/2] arm: shmobile: lager: enable HS-USB

[Sergei Shtylyov]

Hello.

On 10/07/2014 04:19 PM, Yoshihiro Shimoda wrote:

>>> Since this board doesn't have USB ID pin, we assumes the GP5_18 (USB0_PWEN)
>>> is an ID pin because the gpio is high when the SW5 is Pin 3 side.

>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>>    arch/arm/boot/dts/r8a7790-lager.dts |    5 +++++
>>>    1 file changed, 5 insertions(+)

>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 719979e..011254a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -446,3 +446,8 @@
>>>            };
>>>        };
>>>    };
>>> +
>>> +&hsusb {
>>> +    status = "okay";
>>> +    renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_HIGH>;
>>> +};

>>     As I said before, this is not enough. We need pinctrl-related props. Same is true for other boards.

> Thank you very much for the point again.
> Finally I understood what you said before.
> I will start studying the pinctrl world.

    Looks like it will be quicker if I post v3 of your patches.

    Unfortunately, there'll be pinctrl-related error messages in the log if 
the internal PCI and HS-USB drivers are enabled together but everything should 
still work.

> Best regards,
> Yoshihiro Shimoda

WBR, Sergei