From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk
Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm: shmobile: lager: enable HS-USB
Date: Tue, 7 Oct 2014 21:19:30 +0900 [thread overview]
Message-ID: <5433DA52.2020005@renesas.com> (raw)
In-Reply-To: <5433D18B.6050208@cogentembedded.com>
(2014/10/07 20:42), Sergei Shtylyov wrote:
> On 10/7/2014 3:10 PM, Yoshihiro Shimoda wrote:
>
>> Since this board doesn't have USB ID pin, we assumes the GP5_18 (USB0_PWEN)
>> is an ID pin because the gpio is high when the SW5 is Pin 3 side.
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>> index 719979e..011254a 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -446,3 +446,8 @@
>> };
>> };
>> };
>> +
>> +&hsusb {
>> + status = "okay";
>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_HIGH>;
>> +};
>
> As I said before, this is not enough. We need pinctrl-related props. Same is true for other boards.
Thank you very much for the point again.
Finally I understood what you said before.
I will start studying the pinctrl world.
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
next prev parent reply other threads:[~2014-10-07 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 11:10 [PATCH v2 0/2] arm: shimobile: add HS-USB device node on r8a7790 Yoshihiro Shimoda
2014-10-07 11:10 ` [PATCH v2 1/2] arm: shmobile: r8a7790: add HS-USB device node Yoshihiro Shimoda
[not found] ` <1412680220-4552-1-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-10-07 11:10 ` [PATCH v2 2/2] arm: shmobile: lager: enable HS-USB Yoshihiro Shimoda
2014-10-07 11:42 ` Sergei Shtylyov
2014-10-07 12:19 ` Yoshihiro Shimoda [this message]
2014-10-07 19:15 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5433DA52.2020005@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).