From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshihiro Shimoda Subject: Re: [PATCH v3 2/2] ARM: shmobile: lager: enable HS-USB Date: Wed, 8 Oct 2014 13:51:02 +0900 Message-ID: <5434C2B6.2030008@renesas.com> References: <2438577.UAUDMkTTWI@wasted.cogentembedded.com> <2298118.7qjLAFjuvd@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2298118.7qjLAFjuvd@wasted.cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Sergei Shtylyov , "horms@verge.net.au" , "linux-sh@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "devicetree@vger.kernel.org" Cc: "magnus.damm@gmail.com" , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hello. (2014/10/08 5:26), Sergei Shtylyov wrote: > From: Yoshihiro Shimoda > > Enable HS-USB device for the Lager board, defining the GPIO that the driver > should check when probing. Since this board doesn't have the OTG ID pin, we > assume that GP5_18 (USB0_PWEN) is an ID pin because it is 1 when the SW5 is > in position 2-3 (meaning USB function) and 0 in other positions. > < snip > > Index: renesas/arch/arm/boot/dts/r8a7790-lager.dts > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7790-lager.dts > +++ renesas/arch/arm/boot/dts/r8a7790-lager.dts > @@ -226,6 +226,11 @@ > renesas,function = "usb0"; > }; > > + hsusb_pins: usb0 { > + renesas,groups = "usb0_ovc_vbus"; Thank you for the v3 patch. I tested this, and kernel log said "GP_5_19 already requested". However, the hsusb on lager uses GP_5_18. Is this correct behavior? sh-pfc e6060000.pfc: pin GP_5_19 already requested by ee090000.pci; cannot claim for e6590000.usb sh-pfc e6060000.pfc: pin-179 (e6590000.usb) status -22 sh-pfc e6060000.pfc: could not request pin 179 (GP_5_19) from group usb0_ovc_vbus on device sh-pfc Best regards, Yoshihiro Shimoda