From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB Date: Thu, 09 Oct 2014 16:51:02 +0400 Message-ID: <543684B6.6060708@cogentembedded.com> References: <1511869.4ca9KHmSFr@wasted.cogentembedded.com> <8674731.7YYzQeH0h1@wasted.cogentembedded.com> <5435DFD6.3050609@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5435DFD6.3050609@renesas.com> Sender: linux-sh-owner@vger.kernel.org To: Yoshihiro Shimoda , "horms@verge.net.au" , "linux-sh@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "devicetree@vger.kernel.org" Cc: "magnus.damm@gmail.com" , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hello. On 10/09/2014 05:07 AM, Yoshihiro Shimoda wrote: >> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver >> should check when probing (which is the ID output from MAX3355 OTG chip). >> Note that there will be pinctrl-related error messages if both internal PCI >> and HS-USB drivers are enabled but they should be just ignored. >> Signed-off-by: Yoshihiro Shimoda >> [Sergei: added pin function/group and prop, moved device node, fixed summary, >> added changelog] >> Signed-off-by: Sergei Shtylyov >> --- >> Changes in version 3: >> - added pinctrl-related properties; >> - moved the HS-USB node to precede the USB PHY node; >> - uppercased "arm" in the summary; >> - added changelog. >> arch/arm/boot/dts/r8a7791-koelsch.dts | 7 +++++++ >> 1 file changed, 7 insertions(+) >> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts >> =================================================================== >> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts >> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts >> @@ -464,6 +464,13 @@ >> pinctrl-names = "default"; >> }; >> >> +&hsusb { >> + status = "okay"; >> + pinctrl-0 = <&usb0_pins>; >> + pinctrl-names = "default"; > Perhaps I don't understand the pinctrl world yet, but I have a question. > In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And, > the "usb0_pins" is related to these USB0 pins. But, as you know, > the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip. The GPIO pins are not requested via pinctrl. > So, would you tell me why koelsch needs the pinctrl? Because at least USB0_OVC/VBUS is used by HS-USB. I decided not to modify the R8A7791 PFC driver in order to create a group consisting of that signal alone (like on R8A7790), because we don't need to read GP7_23 on these boards, unlike Lager. > Best regards, > Yoshihiro Shimoda WBR, Sergei