From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH 01/44] kernel: Add support for poweroff handler call chain Date: Thu, 09 Oct 2014 06:25:29 -0700 Message-ID: <54368CC9.7020100@roeck-us.net> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-2-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Geert Uytterhoeven Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , driverdevel , "devicetree@vger.kernel.org" , lguest@lists.ozlabs.org, ACPI Devel Maling List , alpha , "moderated list:PANASONIC MN10300..." , Cris , linux-efi@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , linux-m32r-ja@ml.linux-m32r.org, "linuxppc-dev@lists.ozlabs.org" , linux-s390 , linux-tegra@vger.kernel.org, "linux-xtensa@linux-xtensa.org" , openipmi-developer@lists.sourceforge.net, uml-devel List-Id: devicetree@vger.kernel.org On 10/09/2014 04:31 AM, Geert Uytterhoeven wrote: > On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote: >> +int register_poweroff_handler_simple(void (*handler)(void), int priority) >> +{ >> + char symname[KSYM_NAME_LEN]; >> + >> + if (poweroff_handler_data.handler) { >> + lookup_symbol_name((unsigned long)poweroff_handler_data.handler, >> + symname); >> + pr_warn("Poweroff function already registered (%s)", symname); >> + lookup_symbol_name((unsigned long)handler, symname); >> + pr_cont(", cannot register %s\n", symname); > > Doesn't %ps work to look up symbols? > > pr_warn("Poweroff function already registered (%ps), cannot register > %ps\n", poweroff_handler_data.handler, handler); > Hi Geert, That is great. One never stops learning. I'll use that. Thanks! Guenter