From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Liu Subject: Re: [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check. Date: Mon, 13 Oct 2014 22:13:17 +0800 Message-ID: <543BDDFD.1030300@linux.intel.com> References: <1412864980-20273-1-git-send-email-yingjoe.chen@mediatek.com> <1412864980-20273-2-git-send-email-yingjoe.chen@mediatek.com> <543BC186.2050701@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <543BC186.2050701-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marc Zyngier , "Joe.C" , Thomas Gleixner Cc: "arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Rob Herring , Mark Rutland , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , "yingjoe.chen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "hc.yen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , "eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , "nathan.chung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , "yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , Sascha Hauer , Olof Johansson , Arnd Bergmann , Pawel Moll , Russell King , Jason Cooper , Benjamin Herrenschmidt , Santosh Shilimkar , Matt Porter , Marc Carino List-Id: devicetree@vger.kernel.org On 2014/10/13 20:11, Marc Zyngier wrote: > On 09/10/14 15:29, Joe.C wrote: >> From: "Joe.C" >> >> Change virq type from unsigned int to int. Otherwise the return value >> check for irq_domain_alloc_irqs will always pass. >> >> Signed-off-by: Joe.C >> --- >> kernel/irq/irqdomain.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >> index 584be46..dd8d3ab 100644 >> --- a/kernel/irq/irqdomain.c >> +++ b/kernel/irq/irqdomain.c >> @@ -469,7 +469,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data) >> struct irq_domain *domain; >> irq_hw_number_t hwirq; >> unsigned int type = IRQ_TYPE_NONE; >> - unsigned int virq; >> + int virq; >> >> domain = irq_data->np ? irq_find_host(irq_data->np) : irq_default_domain; >> if (!domain) { >> > > I'd expect this patch to get folded into Jiang's series. Hi Mark and Joe, Yes, my next version includes this fixup. Regards! Gerry > > Thanks, > > M. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html