From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029CEC001DF for ; Thu, 3 Aug 2023 09:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234925AbjHCJBw (ORCPT ); Thu, 3 Aug 2023 05:01:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234438AbjHCJBo (ORCPT ); Thu, 3 Aug 2023 05:01:44 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90F9DE46; Thu, 3 Aug 2023 02:01:43 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C11B06607194; Thu, 3 Aug 2023 10:01:41 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691053302; bh=pUYaXlFfqBifFESqrUSVqRw1SQKJ2SasbP6x7jXtTuU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UK/YdjPNmyz6kbCFI8t39AFSGPoatAU+uHhlv/Jn0Dmvj9oMlIByLqx8LElX4wMO8 qsmxDAn7vHOQNy/dY9IUDsyHS78ZHPvwWkoSVMDeV8QVkABro02GOfW8wKI5AiML2l 4RaA7ktQ81G8/vpJpaPWPPyP9b41PEFtXGnv4pvvtVg5ojsqalkKhTshQs3QUenTvn QQKPze/ZYiF3RhBQxDVXlE3J2clgb3wqlT9YnDHynIiJ4rjxvZJJCg6zii32n7UrMx AAHhY5tOpAQDLUUKBlBeCACRIuUFz4SSpyAdG3hKfKZoSRDguvlcbEMzASdyb6rSsL RUvnHH/PNjqSw== Message-ID: <543dfd23-af1f-9f14-fdfe-f3187b780c8a@collabora.com> Date: Thu, 3 Aug 2023 11:01:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 7/9] regulator: mt6358: Add missing regulators for MT6366 Content-Language: en-US To: Chen-Yu Tsai , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Mark Brown Cc: Zhiyong Tao , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230803074249.3065586-1-wenst@chromium.org> <20230803074249.3065586-8-wenst@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20230803074249.3065586-8-wenst@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 03/08/23 09:42, Chen-Yu Tsai ha scritto: > When support for the MT6366 PMIC regulators was added, it was assumed > that it had the same functionality as MT6358. In reality there are > differences. A few regulators have different ranges, or were renamed > and repurposed, or removed altogether. > > Add the 3 regulators that were missing from the original submission. > These are added for completeness. VSRAM_CORE is not used in existing > projects. VM18 and VMDDR feed DRAM related consumers, and are not used > in-kernel. > > Signed-off-by: Chen-Yu Tsai VM18/VMDDR: not used in kernel, but even though writing a new vsel is something to completely avoid (on said devices), we can still read the voltage, which may be good for particular debugging usecases, so... Reviewed-by: AngeloGioacchino Del Regno