From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E33AC43217 for ; Thu, 29 Sep 2022 12:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235290AbiI2Mk2 (ORCPT ); Thu, 29 Sep 2022 08:40:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235606AbiI2MkO (ORCPT ); Thu, 29 Sep 2022 08:40:14 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA0355E55D for ; Thu, 29 Sep 2022 05:40:09 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id c7so1369321ljm.12 for ; Thu, 29 Sep 2022 05:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=dhh6nNTG3cQbu2+/UY4E9ECxQouXbUNsJMhUFHHFteY=; b=kWS+mX1fzHpWgp4sKzzasMuSVtCPi3rvmO8sCBs5g2Y6chi47zlezfb2AVmU2U7U9k 0NpwCbbn904CxatBISjO55b5M90Yk8uaI2eW/Kk8G7iQI3GS0TCEWZGqf/Zwk2DD8D8j xF0Xz9tIPS0I1th3mXRyJTRB1MS0RtK+ynTvlj0ictG8lkpVzXV9i8pij9ZlRvDGIv7X J77Is8JmTttUmWu47FpWgnBtoLOrwvd2BLLzGuRfuc8YKQkupTlQihEEv0QAprebBud9 QKocE8xLpY8ZVurU60EDOo+wVWgytUElsVs7t1Nr8nuTT2FoxDG/WcOdJI227sChT+4K HCug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=dhh6nNTG3cQbu2+/UY4E9ECxQouXbUNsJMhUFHHFteY=; b=iyC70TRgSAmgi6vQCptVWJERKWAeIxN3dVl7wvTXGdkyZP1EUfrq5wMBkET0a8Bubf kfkr/pjQE0qk918Yha5i3KB+mDc0mNRRTmyIAjumtaVI3eo3mn9lHwt6w1gityzij25D 6M/yzuwY3M3TWxzT4lMzfsswmjP9ChVE9e2YIDvSSkK4DPUyslmPCyQ9tiLPOdtEs/j7 MsUaU+MQ0JHBo97cEefhx+oPO0TOnjw7Rzg3xxGagZNhOmmI+zRqOcd54BJphxebRC+5 kYQpWghIkpg8N6E3305emJiLXW8JvmKNp1QUUV1eGlhJgdAdNbmp/ME1ROzYqFdSs0JY XFOg== X-Gm-Message-State: ACrzQf3rf6M6x+TavrTnIkIo8jTP3D5T+QchTVsojWifkwif0IjQCcr/ Gc+mQNEWOvIwRnillXk4oQIjBg== X-Google-Smtp-Source: AMsMyM6F+WpFg+vop57ZHvOS+i+7ShMPC3QW8oqdWbw+jDkUFuaaoSf9WA/vKypuhtRzTjzyUPW98g== X-Received: by 2002:a2e:a0cc:0:b0:26d:b6c8:ff8a with SMTP id f12-20020a2ea0cc000000b0026db6c8ff8amr1088268ljm.492.1664455207490; Thu, 29 Sep 2022 05:40:07 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o17-20020a056512051100b004a054535826sm777972lfb.24.2022.09.29.05.40.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 05:40:06 -0700 (PDT) Message-ID: <5445adda-80e6-41d0-9786-c26d253631c9@linaro.org> Date: Thu, 29 Sep 2022 14:40:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 2/2] dt-bindings: add bindings for QCOM flash LED Content-Language: en-US To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Rob Herring , Krzysztof Kozlowski , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Cc: collinsd@codeaurora.org, subbaram@codeaurora.org References: <20220929121544.1064279-1-quic_fenglinw@quicinc.com> <20220929121544.1064279-3-quic_fenglinw@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20220929121544.1064279-3-quic_fenglinw@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/09/2022 14:15, Fenglin Wu wrote: > Add binding document for flash LED module inside Qualcomm Technologies, > Inc. PMICs. > > Signed-off-by: Fenglin Wu Thank you for your patch. There is something to discuss/improve. > + reg: > + description: address offset of the flash LED controller > + maxItems: 1 > + > +patternProperties: > + "^led[0-3]$": In such case: ^led-[0-9]$" > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + description: | > + Represents the physical LED components which are connected to the > + flash LED channels' output. > + > + properties: > + led-sources: > + description: | > + The HW indices of the flash LED channels that connect to the > + physical LED > + allOf: > + - minItems: 1 > + maxItems: 2 > + items: > + enum: [1, 2, 3, 4] > + > + led-max-microamp: > + description: | > + The maximum current value when LED is not operating in flash mode (i.e. torch mode) > + Valid values when an LED is connected to one flash LED channel: > + 5000 - 500000, step by 5000 > + Valid values when an LED is connected to two flash LED channels: > + 10000 - 1000000, step by 10000 > + minimum: 5000 > + maximum: 1000000 > + > + flash-max-microamp: > + description: | > + The maximum current value when LED is operating in flash mode. > + Valid values when an LED is connected to one flash LED channel: > + 12500 - 1500000, step by 12500 > + Valid values when an LED is connected to two flash LED channels: > + 25000 - 2000000, step by 12500 > + minimum: 12500 > + maximum: 2000000 > + > + flash-max-timeout-us: > + description: | > + The maximum timeout value when LED is operating in flash mode. > + Valid values: 10000 - 1280000, step by 10000 > + minimum: 10000 > + maximum: 1280000 > + > + required: > + - led-sources > + - led-max-microamp > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + spmi_bus { No underscores in node names, so just "bus" > + #address-cells = <1>; > + #size-cells = <0>; Best regards, Krzysztof