From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct Date: Tue, 21 Oct 2014 11:40:00 +0200 Message-ID: <544629F0.3090505@gmail.com> References: <1413882477-27922-1-git-send-email-sebastian.hesselbarth@gmail.com> <1413882477-27922-2-git-send-email-sebastian.hesselbarth@gmail.com> <54462865.6000205@ti.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <54462865.6000205@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: =?UTF-8?B?QW50b2luZSBUw6luYXJ0?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: > On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: >> Currently, Berlin SATA PHY driver assumes PHY_BASE address being >> constant. While this PHY_BASE is correct for BG2Q, older BG2 PHY_BAS= E >> is different. Prepare the driver for BG2 support by moving the phy_b= ase >> into private driver data. >> >> Acked-by: Antoine T=C3=A9nart >> Signed-off-by: Sebastian Hesselbarth =2E.. >> --- >> drivers/phy/phy-berlin-sata.c | 42 ++++++++++++++++++++++++++++---= ----------- >> 1 file changed, 28 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/phy/phy-berlin-sata.c b/drivers/phy/phy-berlin-= sata.c >> index 69ced52d72aa..9682b0f66177 100644 >> --- a/drivers/phy/phy-berlin-sata.c >> +++ b/drivers/phy/phy-berlin-sata.c >> @@ -30,7 +30,7 @@ >> #define MBUS_WRITE_REQUEST_SIZE_128 (BIT(2) << 16) >> #define MBUS_READ_REQUEST_SIZE_128 (BIT(2) << 19) >> >> -#define PHY_BASE 0x200 >> +#define BG2Q_PHY_BASE 0x200 [...] >> +static u32 bg2q_sata_phy_base =3D BG2Q_PHY_BASE; >> + >> +static const struct of_device_id phy_berlin_sata_of_match[] =3D { >> + { >> + .compatible =3D "marvell,berlin2q-sata-phy", >> + .data =3D &bg2q_sata_phy_base, > > Can't the base directly come from dt? You are suggesting a "marvell,phy-base-address" property, right? I have no strong opinion about it, I accept your call (or DT maintainer ones). Sebastian