From: Nishanth Menon <nm@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: Tony Lindgren <tony@atomide.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org,
"Franklin Cooper Jr." <fcooper@ti.com>
Subject: Re: [PATCH] ARM: dts: DRA7: Add aliases for all serial ports
Date: Tue, 21 Oct 2014 15:07:07 -0500 [thread overview]
Message-ID: <5446BCEB.3020708@ti.com> (raw)
In-Reply-To: <3461773.MMIsJQMVIu@wuerfel>
On 10/21/2014 02:57 PM, Arnd Bergmann wrote:
> On Tuesday 21 October 2014 11:18:15 Nishanth Menon wrote:
>> Add serial port aliases for consoles > 6.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> arch/arm/boot/dts/dra7.dtsi | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 9cc9843..208dd83 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -34,6 +34,10 @@
>> serial3 = &uart4;
>> serial4 = &uart5;
>> serial5 = &uart6;
>> + serial6 = &uart7;
>> + serial7 = &uart8;
>> + serial8 = &uart9;
>> + serial9 = &uart10;
>>
>
> I think this was wrong to start with: The aliases should be in the per-board
> .dts file and only list the ones that are actually connected to the outside.
>
> Otherwise the numbering won't match what's written on the board.
At least in the case of DRA7 boards, they are not written specifically
since they come out over onboard FTDI usb2serial.
This will at least ensure that /dev/ttyO9 will always point to uart10
no matter the board, instead of having ttyO0 always pointing to
console serial port no matter the board (and having to guess which
figure out it actually was aliased to).
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-10-21 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 16:18 [PATCH] ARM: dts: DRA7: Add aliases for all serial ports Nishanth Menon
2014-10-21 19:57 ` Arnd Bergmann
2014-10-21 20:07 ` Nishanth Menon [this message]
[not found] ` <5446BCEB.3020708-l0cyMroinI0@public.gmane.org>
2014-11-10 23:49 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5446BCEB.3020708@ti.com \
--to=nm@ti.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).