From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v13 4/5] ARM: dts: add main Thermal info to rk3288 Date: Fri, 24 Oct 2014 09:08:52 +0800 Message-ID: <5449A6A4.3070608@rock-chips.com> References: <1414057207-1576-1-git-send-email-caesar.wang@rock-chips.com> <1414057207-1576-5-git-send-email-caesar.wang@rock-chips.com> <20141024004625.GD9463@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20141024004625.GD9463@dtor-ws> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Torokhov Cc: heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, zyf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, cjf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: devicetree@vger.kernel.org Dmitry, =E5=9C=A8 2014/10/24 8:46, Dmitry Torokhov =E5=86=99=E9=81=93: > Hi Caesar, > > On Thu, Oct 23, 2014 at 05:40:06PM +0800, Caesar Wang wrote: >> This patch is depend on rk3288-thermal.dtsi,or >> it will compile error. >> >> If the temperature over a period of time High,over 120C >> the resulting TSHUT gave CRU module,let it reset >> the entire chip,or via GPIO give PMIC. >> >> Signed-off-by: Caesar Wang >> --- >> arch/arm/boot/dts/rk3288.dtsi | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk328= 8.dtsi >> index cb18bb4..85fc17a 100644 >> --- a/arch/arm/boot/dts/rk3288.dtsi >> +++ b/arch/arm/boot/dts/rk3288.dtsi >> @@ -15,6 +15,7 @@ >> #include >> #include >> #include >> +#include >> #include "skeleton.dtsi" >> =20 >> / { >> @@ -66,6 +67,7 @@ >> 216000 900000 >> 126000 900000 >> >; >> + #cooling-cells =3D <2>; /* min followed by max */ >> clock-latency =3D <40000>; >> clocks =3D <&cru ARMCLK>; >> }; >> @@ -346,6 +348,19 @@ >> status =3D "disabled"; >> }; >> =20 >> + tsadc: tsadc@ff280000 { >> + compatible =3D "rockchip,rk3288-tsadc"; >> + reg =3D <0xff280000 0x100>; >> + interrupts =3D ; >> + clocks =3D <&cru SCLK_TSADC>, <&cru PCLK_TSADC>; >> + clock-names =3D "tsadc", "apb_pclk"; >> + pinctrl-names =3D "default"; >> + pinctrl-0 =3D <&otp_out>; >> + #thermal-sensor-cells =3D <1>; >> + hw-shut-temp =3D <120000>; > I do not think this is a good value. You have (in the other DTS file) > passive trip point at 80 and critical (which should result in orderly > shutdown) at 125. But here you define hardware-controlled shutdown at > 120C, which is backwards. You should have: > > passive <=3D critical <=3D hardware Hmmm.... but, the system will shutdown when temperature over critial value, there is no chance of triggering the TSHUT. If the temperature over a period of time High,as we know, the resulting TSHUT gave CRU module,let it hot-reset the entire chip, or via GPIO give PMIC cold-reset the entire chip. > Thanks. > --=20 Best regards, Caesar -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html