From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 5/8] regulator: max77686: Initialize opmode explicitly to normal mode Date: Mon, 27 Oct 2014 20:51:33 +0100 Message-ID: <544EA245.7010100@collabora.co.uk> References: <1414422226-10948-1-git-send-email-k.kozlowski@samsung.com> <1414422226-10948-6-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1414422226-10948-6-git-send-email-k.kozlowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Krzysztof Kozlowski , Samuel Ortiz , Lee Jones , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, Ben Dooks , Kukjin Kim , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Cc: Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Chanwoo Choi List-Id: devicetree@vger.kernel.org Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: > Minor nit: Initialize the opmode for each regulator to normal mode in a > readable explicit way. > > Signed-off-by: Krzysztof Kozlowski > Suggested-by: Javier Martinez Canillas > --- > drivers/regulator/max77686.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c > index 7930b4f82c0b..e5738c363f07 100644 > --- a/drivers/regulator/max77686.c > +++ b/drivers/regulator/max77686.c > @@ -507,8 +507,8 @@ static int max77686_pmic_probe(struct platform_device *pdev) > config.init_data = max77686->regulators[i].initdata; > config.of_node = max77686->regulators[i].of_node; > > - max77686->opmode[i] = regulators[i].enable_mask >> > - max77686_get_opmode_shift(i); > + max77686->opmode[i] = MAX77686_NORMAL; > + > rdev = devm_regulator_register(&pdev->dev, > ®ulators[i], &config); > if (IS_ERR(rdev)) { > Reviewed-by: Javier Martinez Canillas Best regards, Javier