From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v4 0/5] simplefb: add clock handling code Date: Tue, 28 Oct 2014 12:08:04 +0100 Message-ID: <544F7914.8090007@redhat.com> References: <1413996311-4287-1-git-send-email-hdegoede@redhat.com> <544F737A.7000109@ti.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <544F737A.7000109-l0cyMroinI0@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Tomi Valkeinen Cc: Stephen Warren , Jean-Christophe Plagniol-Villard , Grant Likely , Rob Herring , Luc Verhaegen , Maxime Ripard , Mike Turquette , David Herrmann , Geert Uytterhoeven , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 10/28/2014 11:44 AM, Tomi Valkeinen wrote: > On 22/10/14 19:45, Hans de Goede wrote: > >> Since we seem to have broad agreement on how to move forward with this, I >> would like to ask you to please merge this patch-set for 3.19. >> >> I know 3.19 is still somewhat ar away, but I would like to submit the u-boot >> side of this to upstream ASAP, so can you please let me know if you plan to >> take this patch-set for 3.19 soon ? > > This series looks fine to me, except patch 3 is missing a description, Description for patch 3: "Add a proper struct describing simplefb private data, with the palette in there, instead of directly storing the palette in the fb_info->par pointer." > and patch 4 makes the desc a continuation of the subject. Description for patch 4: "Use the usual kernel style of goto error_foo to free resources on probe error. This is a preparation patch for adding clocks support. While at it update ioremap_wc error return from ENODEV to ENOMEM." > Each patch should have a description (independent from subject). Ok, I'll remember that for future patches. > No need to resend, I can cook up something for those, or I can edit the > descs if you provide the text. Descriptions provided above, thanks! > So if there are no strong objections, I'll queue this for 3.19. Regards, Hans