From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>,
alsa-devel@alsa-project.org, Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
linux-xtensa@linux-xtensa.org, Takashi Iwai <tiwai@suse.de>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform
Date: Tue, 28 Oct 2014 17:39:13 +0100 [thread overview]
Message-ID: <544FC6B1.1060002@metafoo.de> (raw)
In-Reply-To: <20141028160414.GY18557@sirena.org.uk>
On 10/28/2014 05:04 PM, Mark Brown wrote:
> On Tue, Oct 28, 2014 at 04:58:24PM +0100, Lars-Peter Clausen wrote:
>> On 10/27/2014 08:07 PM, Max Filippov wrote:
>
>>> + if (tx_active) {
>>> + if (i2s->tx_fifo_high < 256)
>>> + xtfpga_i2s_refill_fifo(i2s);
>>> + else
>>> + tasklet_hi_schedule(&i2s->refill_fifo);
>
>> Maybe use threaded IRQs instead of IRQ + tasklet.
>
> Is that going to play nicely with the fact that the interrupt can be
> shared and the desire to (AFAICT) do NAPI style stuff with the interrupt
> disabled for long periods?
>
Threaded interrupts got support for interrupt sharing a while ago, so I
guess yes. I think it will even work better than the tasklet approach. You
can configure the IRQ to disable itself as long as the thread is running.
- Lars
next prev parent reply other threads:[~2014-10-28 16:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 19:07 [PATCH] ASoC: add xtensa xtfpga I2S interface and platform Max Filippov
2014-10-27 19:32 ` Mark Brown
2014-10-27 20:38 ` Max Filippov
2014-10-28 15:42 ` Mark Brown
2014-10-28 17:00 ` Max Filippov
2014-10-28 17:38 ` Mark Brown
2014-10-28 18:11 ` Max Filippov
2014-10-28 21:34 ` Mark Brown
2014-10-29 14:19 ` Max Filippov
2014-10-29 14:23 ` Max Filippov
2014-10-29 21:02 ` Mark Brown
2014-10-29 21:10 ` Max Filippov
2014-10-29 21:16 ` Mark Brown
2014-10-28 15:58 ` [alsa-devel] " Lars-Peter Clausen
[not found] ` <544FBD20.5000604-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-10-28 16:04 ` Mark Brown
2014-10-28 16:39 ` Lars-Peter Clausen [this message]
2014-10-28 16:47 ` Takashi Iwai
2014-10-28 17:06 ` Mark Brown
2014-10-28 17:16 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FC6B1.1060002@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jcmvbkbc@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).