From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 1/2] regulator: Document binding for regulator suspend voltage Date: Sat, 01 Nov 2014 09:45:46 +0100 Message-ID: <54549DBA.5020102@collabora.co.uk> References: <1414813978-32233-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1414813978-32233-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson , Mark Brown Cc: Heiko Stuebner , Chris Zhong , Andrew Bresticker , Chanwoo Choi , Kyungmin Park , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, carlos-FEoyFZUZMvJAfugRpC6u6w@public.gmane.org, rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, jkosina-AlSwsSmVLrQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Doug, On 11/01/2014 04:52 AM, Doug Anderson wrote: > This patch builds upon (291d761 regulator: Document binding for > regulator suspend state for PM state) to allow setting the uV in > addition to the state at suspend time. > > Signed-off-by: Doug Anderson > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt > index aaad615..4e7ed76 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -28,6 +28,8 @@ Optional properties: > - regulator-state-[mem/disk] node has following common properties: > - regulator-on-in-suspend: regulator should be on in suspend state. > - regulator-off-in-suspend: regulator should be off in suspend state. > + - regulator-suspend-microvolt: regulator should be set to this voltage > + in suspend. The patch looks good to me: Reviewed-by: Javier Martinez Canillas On thing I wonder is if the binding should say that the suspend voltage is independent of the runtime one and it may be outside of the runtime range? Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html