* [PATCH 1/2] regulator: Document binding for regulator suspend voltage
@ 2014-11-01 3:52 Doug Anderson
[not found] ` <1414813978-32233-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2014-11-01 3:52 UTC (permalink / raw)
To: Mark Brown
Cc: javier.martinez, Heiko Stuebner, Chris Zhong, Andrew Bresticker,
Chanwoo Choi, Kyungmin Park, linux-arm-kernel, linux-rockchip,
Doug Anderson, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, carlos, rdunlap, jkosina, devicetree, linux-kernel
This patch builds upon (291d761 regulator: Document binding for
regulator suspend state for PM state) to allow setting the uV in
addition to the state at suspend time.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
index aaad615..4e7ed76 100644
--- a/Documentation/devicetree/bindings/regulator/regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/regulator.txt
@@ -28,6 +28,8 @@ Optional properties:
- regulator-state-[mem/disk] node has following common properties:
- regulator-on-in-suspend: regulator should be on in suspend state.
- regulator-off-in-suspend: regulator should be off in suspend state.
+ - regulator-suspend-microvolt: regulator should be set to this voltage
+ in suspend.
Deprecated properties:
- regulator-compatible: If a regulator chip contains multiple
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] regulator: Document binding for regulator suspend voltage
[not found] ` <1414813978-32233-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
@ 2014-11-01 8:45 ` Javier Martinez Canillas
2014-11-03 0:27 ` Chris Zhong
2014-11-03 12:29 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2014-11-01 8:45 UTC (permalink / raw)
To: Doug Anderson, Mark Brown
Cc: Heiko Stuebner, Chris Zhong, Andrew Bresticker, Chanwoo Choi,
Kyungmin Park, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, carlos-FEoyFZUZMvJAfugRpC6u6w,
rdunlap-wEGCiKHe2LqWVfeAwA7xHQ, jkosina-AlSwsSmVLrQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hello Doug,
On 11/01/2014 04:52 AM, Doug Anderson wrote:
> This patch builds upon (291d761 regulator: Document binding for
> regulator suspend state for PM state) to allow setting the uV in
> addition to the state at suspend time.
>
> Signed-off-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
> index aaad615..4e7ed76 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
> @@ -28,6 +28,8 @@ Optional properties:
> - regulator-state-[mem/disk] node has following common properties:
> - regulator-on-in-suspend: regulator should be on in suspend state.
> - regulator-off-in-suspend: regulator should be off in suspend state.
> + - regulator-suspend-microvolt: regulator should be set to this voltage
> + in suspend.
The patch looks good to me:
Reviewed-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
On thing I wonder is if the binding should say that the suspend voltage is
independent of the runtime one and it may be outside of the runtime range?
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] regulator: Document binding for regulator suspend voltage
2014-11-01 8:45 ` Javier Martinez Canillas
@ 2014-11-03 0:27 ` Chris Zhong
0 siblings, 0 replies; 4+ messages in thread
From: Chris Zhong @ 2014-11-03 0:27 UTC (permalink / raw)
To: Javier Martinez Canillas, Doug Anderson, Mark Brown
Cc: Heiko Stuebner, Andrew Bresticker, Chanwoo Choi, Kyungmin Park,
linux-arm-kernel, linux-rockchip, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, carlos, rdunlap, jkosina,
devicetree, linux-kernel
On 11/01/2014 04:45 PM, Javier Martinez Canillas wrote:
> Hello Doug,
>
> On 11/01/2014 04:52 AM, Doug Anderson wrote:
>> This patch builds upon (291d761 regulator: Document binding for
>> regulator suspend state for PM state) to allow setting the uV in
>> addition to the state at suspend time.
>>
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>> ---
>> Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
>> index aaad615..4e7ed76 100644
>> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
>> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
>> @@ -28,6 +28,8 @@ Optional properties:
>> - regulator-state-[mem/disk] node has following common properties:
>> - regulator-on-in-suspend: regulator should be on in suspend state.
>> - regulator-off-in-suspend: regulator should be off in suspend state.
>> + - regulator-suspend-microvolt: regulator should be set to this voltage
>> + in suspend.
> The patch looks good to me:
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> On thing I wonder is if the binding should say that the suspend voltage is
> independent of the runtime one and it may be outside of the runtime range?
>
> Best regards,
> Javier
>
>
>
Reviewed-by: Chris Zhong <zyw@rock-chips.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] regulator: Document binding for regulator suspend voltage
[not found] ` <1414813978-32233-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-11-01 8:45 ` Javier Martinez Canillas
@ 2014-11-03 12:29 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-11-03 12:29 UTC (permalink / raw)
To: Doug Anderson
Cc: javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ, Heiko Stuebner,
Chris Zhong, Andrew Bresticker, Chanwoo Choi, Kyungmin Park,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, carlos-FEoyFZUZMvJAfugRpC6u6w,
rdunlap-wEGCiKHe2LqWVfeAwA7xHQ, jkosina-AlSwsSmVLrQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
On Fri, Oct 31, 2014 at 08:52:57PM -0700, Doug Anderson wrote:
> This patch builds upon (291d761 regulator: Document binding for
> regulator suspend state for PM state) to allow setting the uV in
> addition to the state at suspend time.
Applied both, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-03 12:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-01 3:52 [PATCH 1/2] regulator: Document binding for regulator suspend voltage Doug Anderson
[not found] ` <1414813978-32233-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-11-01 8:45 ` Javier Martinez Canillas
2014-11-03 0:27 ` Chris Zhong
2014-11-03 12:29 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).