From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v4 03/14] regulator: of: Add regulator desc param to of_get_regulator_init_data() Date: Mon, 03 Nov 2014 17:11:43 +0100 Message-ID: <5457A93F.70308@collabora.co.uk> References: <1415025649-8119-1-git-send-email-javier.martinez@collabora.co.uk> <1415025649-8119-4-git-send-email-javier.martinez@collabora.co.uk> <20141103153303.GQ3815@sirena.org.uk> <5457A3D2.1090602@collabora.co.uk> <20141103155909.GX3815@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141103155909.GX3815@sirena.org.uk> Sender: linux-samsung-soc-owner@vger.kernel.org To: Mark Brown Cc: Kukjin Kim , Chanwoo Choi , Olof Johansson , Chris Zhong , Krzysztof Kozlowski , Abhilash Kesavan , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 11/03/2014 04:59 PM, Mark Brown wrote: > No, it's only *currently* used for that. If we don't bother passing the > descriptor in then future additions which make use of it (including > adding mode operations to existing drivers) won't work and it might not > be obvious why. > fair enough. > You're already going through and modifying every single driver and all > of those I looked at already had references to the descriptor in > adjacent code or a global descriptor for the one regulator supported by > the driver. > Ok, I'll make sure that all drivers passes the descriptor. Best regards, Javier