From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Maramaina Naresh <quic_mnaresh@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_cang@quicinc.com, quic_nguyenb@quicinc.com
Subject: Re: [PATCH V1 1/4] dt-bindings: ufs: qcom: Add qos property
Date: Tue, 10 Oct 2023 18:37:11 +0200 [thread overview]
Message-ID: <5458734c-b9ff-4351-9bcd-c3dd7538f135@linaro.org> (raw)
In-Reply-To: <1696952947-18062-2-git-send-email-quic_mnaresh@quicinc.com>
On 10/10/23 17:49, Maramaina Naresh wrote:
> Add bindings for per-cpu QoS for QCOM UFS. This improves random io
> performance by 20% for QCOM UFS.
The bindings addition improves performance? Cool :P
Please explain your changes and provide the "why".
[...]
> @@ -318,5 +326,13 @@ examples:
> <0 0>,
> <0 0>;
> qcom,ice = <&ice>;
> + qos0 {
Looks like the indentation is off, also missing newline before subnodes.
> + cpumask = <0x0f>;This should be a CPU phandle array instead. Besides, can we not
determine this dynamically?
> + vote = <44>;
> + };
> + qos1 {
Missing newline between subnodes.
Konrad
next prev parent reply other threads:[~2023-10-10 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 15:49 [PATCH V1 0/4] Add per-cpu PM QoS support for QCOM UFS Maramaina Naresh
2023-10-10 15:49 ` [PATCH V1 1/4] dt-bindings: ufs: qcom: Add qos property Maramaina Naresh
2023-10-10 16:27 ` Rob Herring
2023-10-10 16:37 ` Konrad Dybcio [this message]
[not found] ` <6a85761a-3dae-43fd-9b11-3d2edc56ad7e@quicinc.com>
2023-10-21 17:22 ` Konrad Dybcio
2023-10-11 7:37 ` kernel test robot
2023-10-12 12:54 ` Krzysztof Kozlowski
2023-10-10 15:49 ` [PATCH V1 2/4] ufs: ufs-qcom: Add per-cpu PM QoS support for ufs Maramaina Naresh
2023-10-10 15:49 ` [PATCH V1 3/4] ufs: ufs-qcom: Add per-cpu PM QoS vote " Maramaina Naresh
2023-10-10 16:41 ` Konrad Dybcio
2023-10-10 15:49 ` [PATCH V1 4/4] arm64: dts: qcom: sm8550: Add per-cpu PM QoS " Maramaina Naresh
2023-10-11 20:56 ` [PATCH V1 0/4] Add per-cpu PM QoS support for QCOM UFS Bart Van Assche
2023-10-20 6:45 ` Maramaina Naresh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5458734c-b9ff-4351-9bcd-c3dd7538f135@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.ibm.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=quic_mnaresh@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).