Re: [PATCH v4 2/8] phy: miphy28lp: Add PHY header file for DT x Driver defines

[Kishon Vijay Abraham I <kishon@ti.com>]

On Tuesday 04 November 2014 03:28 PM, Gabriel Fernandez wrote:
> Hi Kishon,
> 
> Sure, I'll update my patch set and sent to you soon as possible.

cool, thanks.

-Kishon
> 
> Best Regards
> 
> Gabriel
> 
> On 4 November 2014 10:25, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> Hi Gabriel,
>>
>> On Wednesday 22 October 2014 12:44 PM, Gabriel FERNANDEZ wrote:
>>> This provides the shared header file which will be reference from both
>>> PHY driver and its associated Device Tree node(s).
>>>
>>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
>>> ---
>>>  include/dt-bindings/phy/phy.h | 17 +++++++++++++++++
>>>  1 file changed, 17 insertions(+)
>>>  create mode 100644 include/dt-bindings/phy/phy.h
>>>
>>> diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h
>>> new file mode 100644
>>> index 0000000..a142c69
>>> --- /dev/null
>>> +++ b/include/dt-bindings/phy/phy.h
>>> @@ -0,0 +1,17 @@
>>> +/*
>>> + *
>>> + * This header provides constants for the phy framework
>>> + *
>>> + * Copyright (C) 2014 STMicroelectronics
>>> + * Author: Gabriel Fernandez <gabriel.fernandez@st.com>
>>> + * License terms:  GNU General Public License (GPL), version 2
>>> + */
>>> +
>>> +#ifndef _DT_BINDINGS_PHY
>>> +#define _DT_BINDINGS_PHY
>>> +
>>> +#define PHY_TYPE_SATA                1
>>> +#define PHY_TYPE_PCIE                2
>>> +#define PHY_TYPE_USB         3
>>
>> Can we have a separate #define for USB2 and USB3? Looks like Gregory will need
>> it for Armada 375 SoC.
>>
>> Thanks
>> Kishon