From mboxrd@z Thu Jan  1 00:00:00 1970
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: Re: [PATCH v5 2/5] regulator: Add function to map modes to struct
 regulator_desc
Date: Fri, 07 Nov 2014 17:17:52 +0100
Message-ID: <545CF0B0.3030009@collabora.co.uk>
References: <1415365205-27630-1-git-send-email-javier.martinez@collabora.co.uk> <1415365205-27630-3-git-send-email-javier.martinez@collabora.co.uk> <20141107155400.GU8509@sirena.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Return-path: <linux-samsung-soc-owner@vger.kernel.org>
In-Reply-To: <20141107155400.GU8509@sirena.org.uk>
Sender: linux-samsung-soc-owner@vger.kernel.org
To: Mark Brown <broonie@kernel.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Olof Johansson <olof@lixom.net>, Chris Zhong <zyw@rock-chips.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Abhilash Kesavan <kesavan.abhilash@gmail.com>, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
List-Id: devicetree@vger.kernel.org

On 11/07/2014 04:54 PM, Mark Brown wrote:
> of_map_mode - it's only one mode and this is mapping to/from DT.
>

Ok
 
>> + *             If the callback is not defined, the "regulator-initial-mode"
>> + *             and suspend states "regulator-mode" properties won't be parsed.
> 
> Just remove this, it's pretty obvious at best and going to bit rot at
> worst.
> 

Ok, it was not in a previous version but I added because Krzysztof said
that it may be good to have it documented. I'll remove it.

Best regards,
Javier