Re: [RFC v2 2/3] iio: bindings: Add TI afe4403 heart monitor documentation

Re: [RFC v2 2/3] iio: bindings: Add TI afe4403 heart monitor documentation

[Jonathan Cameron]

On 06/11/14 15:18, Dan Murphy wrote:
> Add the TI afe4403 heart monitor device tree
> binding documentation.  heart_monitors directory
> created under iio.
> 
> Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
As a device tree binding this MUST go to the device tree list
and maintainers.  Cc'd.

I suspect from my review of the driver that there will be a
whole load more stuff to go in here...

> ---
> 
> v2 - Updated per v1 comments - http://marc.info/?l=linux-iio&m=141331404132215&w=2
> 
>  .../bindings/iio/heart_monitor/ti_afe4403.txt      | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt b/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt
> new file mode 100644
> index 0000000..cf75b5a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt
> @@ -0,0 +1,23 @@
> +* Texas Instruments - AFE4403 Heart rate and Pulse Oximeter
> +
> +The device consists of a low-noise receiver channel
> +with an integrated analog-to-digital converter (ADC),
> +an LED transmit section, and diagnostics for sensor and LED fault detection.
> +
> +Required properties:
> +  - compatible: Must contain "ti,afe4403".
> +  - ste-gpio: GPIO for the spi control line
> +  - data-ready-gpio: GPIO interrupt when the afe4403 has data
Does this actually need to be a gpio?  Doesn't look like it from the driver.
As such should be handled as a generic interrupt both here and in the driver.

> +  - led-supply: Chip supply to the device
> +
> +Optional properties:
> +  - reset-gpio: GPIO used to reset the device via HW
> +
> +Example:
> +
> +&heart_rate {
> +	compatible = "ti,afe4403";
> +	ste-gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
> +	data-ready-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> +	led-supply = <&vbat>;
> +};
> 

Re: [RFC v2 2/3] iio: bindings: Add TI afe4403 heart monitor documentation

[Dan Murphy]

Jonathan

On 11/08/2014 05:48 AM, Jonathan Cameron wrote:
> On 06/11/14 15:18, Dan Murphy wrote:
>> Add the TI afe4403 heart monitor device tree
>> binding documentation.  heart_monitors directory
>> created under iio.
>>
>> Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
> As a device tree binding this MUST go to the device tree list
> and maintainers.  Cc'd.

Yeah forgot to add the list

>
> I suspect from my review of the driver that there will be a
> whole load more stuff to go in here...
>
>> ---
>>
>> v2 - Updated per v1 comments - http://marc.info/?l=linux-iio&m=141331404132215&w=2
>>
>>  .../bindings/iio/heart_monitor/ti_afe4403.txt      | 23 ++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt b/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt
>> new file mode 100644
>> index 0000000..cf75b5a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt
>> @@ -0,0 +1,23 @@
>> +* Texas Instruments - AFE4403 Heart rate and Pulse Oximeter
>> +
>> +The device consists of a low-noise receiver channel
>> +with an integrated analog-to-digital converter (ADC),
>> +an LED transmit section, and diagnostics for sensor and LED fault detection.
>> +
>> +Required properties:
>> +  - compatible: Must contain "ti,afe4403".
>> +  - ste-gpio: GPIO for the spi control line
>> +  - data-ready-gpio: GPIO interrupt when the afe4403 has data
> Does this actually need to be a gpio?  Doesn't look like it from the driver.
> As such should be handled as a generic interrupt both here and in the driver.

Well in my setup I connected the data-ready output of the device to a GPIO
and I need to tell the driver which GPIO to use.

Not sure how else to route the signal from the device to a SoC.

>
>> +  - led-supply: Chip supply to the device
>> +
>> +Optional properties:
>> +  - reset-gpio: GPIO used to reset the device via HW
>> +
>> +Example:
>> +
>> +&heart_rate {
>> +	compatible = "ti,afe4403";
>> +	ste-gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
>> +	data-ready-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> +	led-supply = <&vbat>;
>> +};
>>


-- 
------------------
Dan Murphy