From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3D6C7EE2E for ; Tue, 28 Feb 2023 10:58:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231345AbjB1K6c (ORCPT ); Tue, 28 Feb 2023 05:58:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231348AbjB1K6Q (ORCPT ); Tue, 28 Feb 2023 05:58:16 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 154F8B754 for ; Tue, 28 Feb 2023 02:58:03 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso5753066wmb.0 for ; Tue, 28 Feb 2023 02:58:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677581881; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u6A2Sc2TLWOMEQ5y9qjHmMZKsT1Mi1qRqi+sfSjfpO0=; b=QqHiXL8xz6P0TwObJgri1HUKQUaS8QRVLWP1zU/kcdZdLcOZfuS5LDo0CS5erblAss i3mypQ/t5If0PlKVO61jzWGlWmhg5iEbWbVAJTt3c/96K1HPpgFdTgkGsdah4LuMTPwD fnCX9JgcR1J9JaLiR8LQCOAqmX0u0Hh/hRjIgiK5GzJp9UlARoRRiba8GJvtAuACohiF XCvoPuYjEyVDUWaHz3N/HSDzhCIf0MpsRIZzq9mUHo9ch8t7+BCyvKtKV3vDwWCdAWjW hm3QDZr1IgJXPvCyKzLVDXISQaIKaeMJgoaCP4/OgQK0T5wviBJNNPhoAI7f1FICoZbm ZqMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677581881; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u6A2Sc2TLWOMEQ5y9qjHmMZKsT1Mi1qRqi+sfSjfpO0=; b=U7b15u5jaR0tLw1r26FiUhnCtBjqGCgzHljy4BLoMP9hNqquXW4KG9Swgj7RyEmzo+ XTJZtzj968pkpRHQRsxs6pSJOxk89WNIz9RU+hhiXJqvH1oKJhrgmttGytWDiHF5/vz+ OPqQn5NqhN4WGk2SolGm6oGVKYndQWHwwFHNgFzYy5dE7DaEtbnU5lFSxDmB73NkNXIe 6zsBfvF8wp/e9P68YRHnOBRuGGKZ4vlXp1niEw6ow1g3ouzPLLkGXduagbbkAkb8SMOG uH6XRNd8Y3Awj6Va21kaXA1o8Baqjdxs7PmLPSTYGwwH/NGF1XXmorDAtgZwt0iokluf DITw== X-Gm-Message-State: AO0yUKUA4fwl+5DMvNe5t/YQSLJOpguQreSJkcLnB9+D4bpDj1LLSc16 87ELs6lfVQBXiY3aFBj8OdrhiA== X-Google-Smtp-Source: AK7set9aj//n9rmdyGmH3/dOQnO4mTtlCGyI8o1O6rY/P5ntjM8Tk+WDegjEDx/5j8Gn/DHp/NQNyQ== X-Received: by 2002:a05:600c:4d20:b0:3eb:2e66:8 with SMTP id u32-20020a05600c4d2000b003eb2e660008mr1731362wmp.35.1677581881467; Tue, 28 Feb 2023 02:58:01 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id fl16-20020a05600c0b9000b003e1f6e18c95sm16244493wmb.21.2023.02.28.02.57.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 02:58:01 -0800 (PST) Message-ID: <545c23f3-1d68-2bff-89d9-584e3ca31044@linaro.org> Date: Tue, 28 Feb 2023 11:57:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/2] drivers: watchdog: Add StarFive Watchdog driver Content-Language: en-US To: Conor Dooley , Emil Renner Berthing Cc: Xingyu Wu , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Samin Guo , linux-kernel@vger.kernel.org, Conor Dooley References: <20230220081926.267695-1-xingyu.wu@starfivetech.com> <20230220081926.267695-3-xingyu.wu@starfivetech.com> <0ffb02d2-0bbd-fd0d-b0f6-cb5605570050@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/02/2023 11:51, Conor Dooley wrote: > On Tue, Feb 28, 2023 at 11:36:49AM +0100, Emil Renner Berthing wrote: >> On Tue, 28 Feb 2023 at 10:44, Xingyu Wu wrote: >>> On 2023/2/26 22:14, Emil Renner Berthing wrote: >>>> On Mon, 20 Feb 2023 at 09:21, Xingyu Wu wrote: > >>> So the dt-bingdings need to rename, and which one could be better, >>> 'starfive,jh71x0-wdt.yaml' or 'starfive,jh-wdt.yaml'? >> >> Sure, starfive,jh71x0-wdt.yaml sounds good to me. > > I feel like a common comment I see from the dt folks is to not put > wildcards in filenames & just pick the first compatible. > I could very well be wrong on that front though... First compatible is a bit better, unless you are sure this will cover all such compatibles now and in the future. For many bindings the family/wildcards were fine in filename. Best regards, Krzysztof