Re: [PATCH v7 7/7] dt-bindings: add document for dw-hdmi

[Andy Yan <andy.yan@rock-chips.com>]

Sorry, it seems that there is somethings wrong whit my network.
This version maybe sent twice.
On 2014年11月11日 20:24, Mark Rutland wrote:
> On Tue, Nov 11, 2014 at 12:12:32PM +0000, Andy Yan wrote:
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>>
>> Changes in v7: None
>> Changes in v6: None
>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>   .../devicetree/bindings/drm/bridge/dw-hdmi.txt     | 38 ++++++++++++++++++++++
>>   1 file changed, 38 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
>>
>> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
>> new file mode 100644
>> index 0000000..aa7ed17
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
>> @@ -0,0 +1,38 @@
>> +DesignWare HDMI bridge bindings
>> +
>> +Required properities:
>> +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi"
>> +	      "rockchip,rk3288-dw-hdmi"
> s/compatibel/compatible/
   thanks, I will correct it next version.
>
> This should include the _precise_ strings you expect. Please format this
> as a list, e.g.
>
> - compatible: should contain one of:
>    * "fsl,imx6q-hdmi"
>    * "fsl,imx6dl-hdmi"
>    * "rockchip,rk3288-dw-hdmi"
>
   I will do as your suggestion in next version
>> +- reg: physical base address of the controller and length
>> +- ddc-i2c-bus: the ddc i2c bus
>> +- interrupts: The interrupt number to the cpu
> Does the device only have one interrupt? Just describe what this
> logically is, and don't mention the CPU. It'll be plumbed through an
> interrupt controller anyhow.
   this device only have on interrupt for hot plug and other things.
>> +
>> +Optional properties
>> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present
> I don't understand this description. Could you elaborate on this?
     this property is platform specific , it is used to describe the 
register width.
     on imx6, the hdmi register is one byte width, which means the first 
register address
     is 0x0000, the second is 0x0001, but on rk3288, the register is 4 
bytes width, the first
      register address is 0x0000, and the second is 0x0004
>
>> +
>> +Example:
>> +	hdmi: hdmi@0120000 {
>> +		compatible = "fsl,imx6q-hdmi";
>> +		reg = <0x00120000 0x9000>;
>> +		interrupts = <0 115 0x04>;
>> +		gpr = <&gpr>;
>> +		clocks = <&clks 123>, <&clks 124>;
>> +		clock-names = "iahb", "isfr";
> These three properties weren't mentioned in the binding.
    gpr,clocks, port are platform specific property, on
    rk3288, the grf have the similar function as gpr on imx.
    And the clock also have different name on the two platforms.
    the port also different, on imx, the port is ipuxxx, but on rk3288,
    the port is vopx,
    these properties will be mentioned in platform dt binding.
>
>> +		ddc-i2c-bus = <&i2c2>;
>> +
>> +		port@0 {
>> +			reg = <0>;
>> +
>> +			hdmi_mux_0: endpoint {
>> +				remote-endpoint = <&ipu1_di0_hdmi>;
>> +			};
>> +		};
> Please mention the graphics bindings that require graph info.
>
> THanks,
> Mark.
>
>> +
>> +		port@1 {
>> +			reg = <1>;
>> +
>> +			hdmi_mux_1: endpoint {
>> +				remote-endpoint = <&ipu1_di1_hdmi>;
>> +			};
>> +		};
>> +	};
>> -- 
>> 1.9.1
>>
>>
>
>