From: Jiri Slaby <jslaby@suse.cz>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
tushar.behera@linaro.org, daniel@zonque.org,
haojian.zhuang@gmail.com, robert.jarzmik@free.fr,
Grant Likely <grant.likely@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Maxime Bizon <mbizon@freebox.fr>, Jonas Gorski <jogo@openwrt.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH/RFC 3/8] of: Add helper function to check MMIO register endianness
Date: Wed, 12 Nov 2014 10:23:36 +0100 [thread overview]
Message-ID: <54632718.9030603@suse.cz> (raw)
In-Reply-To: <CAJiQ=7ADy1U60R-o1soMyqYWXqw2OqQg7vfB9L5pzeac+Yv=SA@mail.gmail.com>
On 11/12/2014, 10:04 AM, Kevin Cernekee wrote:
>> This should actually return bool and use true/false.
>
> Well, the other APIs currently return an int:
>
> extern int of_device_is_compatible(const struct device_node *device,
> const char *);
> extern int of_device_is_available(const struct device_node *device);
> [...]
> extern int of_machine_is_compatible(const char *compat);
>
> Do you think it is best to change all of them at once, or just the
> newly introduced function?
Possibly fix all these in a separate patch and then add the new one
fixed :).
--
js
suse labs
next prev parent reply other threads:[~2014-11-12 9:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 8:46 [PATCH/RFC 0/8] UART driver support for BMIPS multiplatform kernels Kevin Cernekee
2014-11-12 8:46 ` [PATCH/RFC 1/8] tty: Fallback to use dynamic major number Kevin Cernekee
2014-11-12 8:46 ` [PATCH/RFC 2/8] serial: core: Add big_endian flag Kevin Cernekee
2014-11-12 8:46 ` [PATCH/RFC 3/8] of: Add helper function to check MMIO register endianness Kevin Cernekee
2014-11-12 8:50 ` Jiri Slaby
2014-11-12 9:04 ` Kevin Cernekee
2014-11-12 9:23 ` Jiri Slaby [this message]
2014-11-12 8:46 ` [PATCH/RFC 4/8] serial: pxa: Add fifo-size and {big,native}-endian properties Kevin Cernekee
2014-11-12 9:02 ` Arnd Bergmann
2014-11-12 9:03 ` Jiri Slaby
2014-11-12 9:08 ` Arnd Bergmann
2014-11-12 8:46 ` [PATCH/RFC 5/8] serial: pxa: Make the driver buildable for BCM7xxx set-top platforms Kevin Cernekee
2014-11-12 9:04 ` Arnd Bergmann
2014-11-12 9:19 ` Kevin Cernekee
2014-11-13 9:42 ` Arnd Bergmann
2014-11-13 19:08 ` Kevin Cernekee
2014-11-13 22:34 ` Arnd Bergmann
2014-11-14 21:07 ` Robert Jarzmik
2014-11-12 8:46 ` [PATCH/RFC 6/8] serial: pxa: Update DT binding documentation Kevin Cernekee
2014-11-12 8:46 ` [PATCH/RFC 7/8] serial: earlycon: Set uart_port->big_endian based on DT properties Kevin Cernekee
2014-11-12 8:46 ` [PATCH/RFC 8/8] serial: pxa: Add OF_EARLYCON support Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54632718.9030603@suse.cz \
--to=jslaby@suse.cz \
--cc=cernekee@gmail.com \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=jogo@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=mbizon@freebox.fr \
--cc=robert.jarzmik@free.fr \
--cc=robh@kernel.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).