devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Marek Belisko <marek@goldelico.com>, grant.likely@linaro.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux@arm.linux.org.uk,
	pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
	tony@atomide.com, hns@goldelico.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	bcousson@baylibre.com, galak@codeaurora.org,
	linux-omap@vger.kernel.org, plagnioj@jcrosoft.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] Documentation: DT: Add documentation for ti,opa362 bindings
Date: Wed, 12 Nov 2014 16:00:14 +0200	[thread overview]
Message-ID: <546367EE.3040600@ti.com> (raw)
In-Reply-To: <1415051968-4878-3-git-send-email-marek@goldelico.com>


[-- Attachment #1.1: Type: text/plain, Size: 1196 bytes --]

On 03/11/14 23:59, Marek Belisko wrote:
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
>  .../devicetree/bindings/video/ti,opa362.txt        | 38 ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/video/ti,opa362.txt
> 
> diff --git a/Documentation/devicetree/bindings/video/ti,opa362.txt b/Documentation/devicetree/bindings/video/ti,opa362.txt
> new file mode 100644
> index 0000000..d7ed11a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/ti,opa362.txt
> @@ -0,0 +1,38 @@
> +OPA362 analog video amplifier
> +
> +Required properties:
> +- compatible: "ti,opa362"
> +- gpio: enable/disable output gpio
> +
> +Required node:
> +- Video port 0 for opa362 input
> +- Video port 1 for opa362 output
> +
> +Example:
> +
> +tv_amp: opa362 {
> +	 compatible = "ti,opa362";
> +	 gpios = <&gpio1 23 0>;  /* GPIO to enable video out amplifier */
> +	 
> +	label = "opa362";

opa shouldn't have label property. label is meant for the
end-of-the-chain component, like the connector.

> +	 ports {

Hmm, I think there is extra space before 'ports', maybe below also.

 Tomi



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2014-11-12 14:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03 21:59 [PATCH 0/4] omapdss: Add video output support for gta04 board Marek Belisko
2014-11-03 21:59 ` [PATCH 1/4] video: omapdss: Add opa362 driver Marek Belisko
     [not found]   ` <1415051968-4878-2-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2014-11-12 13:57     ` Tomi Valkeinen
2014-11-12 14:04       ` Belisko Marek
2014-11-03 21:59 ` [PATCH 2/4] Documentation: DT: Add documentation for ti,opa362 bindings Marek Belisko
2014-11-12 14:00   ` Tomi Valkeinen [this message]
2014-11-03 21:59 ` [PATCH 3/4] arm: dts: omap3-gta04: Add handling for tv output Marek Belisko
     [not found]   ` <1415051968-4878-4-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2014-11-10 23:30     ` Tony Lindgren
2014-11-11  7:41       ` Tomi Valkeinen
2014-11-11 15:00         ` Tony Lindgren
2014-11-03 21:59 ` [PATCH 4/4] arm: dts: omap3-gta04: Add static configuration for devconf1 register Marek Belisko
2014-11-10 23:36   ` Tony Lindgren
2014-11-12 21:02     ` Belisko Marek
2014-11-12 21:23       ` Tony Lindgren
     [not found]   ` <1415051968-4878-5-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2014-11-12 12:53     ` Tomi Valkeinen
     [not found]       ` <5463585D.9070209-l0cyMroinI0@public.gmane.org>
2014-11-12 15:02         ` Tony Lindgren
2014-11-13 11:31           ` Tomi Valkeinen
     [not found]             ` <5464969F.30708-l0cyMroinI0@public.gmane.org>
2014-11-13 18:28               ` Tony Lindgren
     [not found]                 ` <20141113182848.GQ26481-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-11-13 22:59                   ` Paul Walmsley
2014-11-13 23:58                     ` Tony Lindgren
2014-11-14  7:32                       ` Tero Kristo
2014-11-14 18:01                         ` Tony Lindgren
2014-11-14 14:36                       ` Grazvydas Ignotas
     [not found]                         ` <CANOLnONkQu-BBvZH5nb+VngCxq=xnk60JkTd6Jha1uFt2j8gJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-14 15:58                           ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546367EE.3040600@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=hns@goldelico.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marek@goldelico.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).