From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Jean-Christophe Plagniol-Villard
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Luc Verhaegen <libv-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
David Herrmann
<dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
"linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH 3/4] simplefb: Change simplefb_init from module_init to fs_initcall
Date: Thu, 13 Nov 2014 13:01:36 +0100 [thread overview]
Message-ID: <54649DA0.8060308@redhat.com> (raw)
In-Reply-To: <CACxGe6sYD-Ow2wcwAKuXpR3A9VZozo2sgz=eEcWXi5ayKd2jWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi,
On 11/13/2014 11:31 AM, Grant Likely wrote:
> On Thu, Nov 13, 2014 at 10:29 AM, Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> On Thu, Nov 13, 2014 at 9:24 AM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>> Hi,
>>>
>>> On 11/13/2014 09:52 AM, Maxime Ripard wrote:
>>>> On Wed, Nov 12, 2014 at 11:08:43PM +0100, Hans de Goede wrote:
>>>>> One of the reasons for having the simplefb nodes in /chosen, and doing
>>>>> explicit enumeration of the nodes there, is too allow enumerating them sooner,
>>>>> so that we get a console earlier on.
>>>>>
>>>>> Doing this earlier then fs_initcall is not useful, since the fb only turns into
>>>>> a console when fbcon intializes, which is a fs_initcall too.
>>>>>
>>>>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>>>> ---
>>>>> drivers/video/fbdev/simplefb.c | 6 +++++-
>>>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
>>>>> index be7d288..8c0c972 100644
>>>>> --- a/drivers/video/fbdev/simplefb.c
>>>>> +++ b/drivers/video/fbdev/simplefb.c
>>>>> @@ -415,7 +415,11 @@ static void __exit simplefb_exit(void)
>>>>> platform_driver_unregister(&simplefb_driver);
>>>>> }
>>>>>
>>>>> -module_init(simplefb_init);
>>>>> +/*
>>>>> + * While this can be a module, if builtin it's most likely the console
>>>>> + * So let's leave module_exit but move module_init to an earlier place
>>>>> + */
>>>>
>>>> Not really related to this patch itself, but do we want to support
>>>> simplefb as a module? It seems like it's going to be most of the time
>>>> broken.
>>>
>>> A valid point, my mean reasoning here is that some may see not being able to
>>> use it as a module as a regression, so I just kept things as is, but I do
>>> agree that it is advisable to just build it in.
>>
>> Like a lot of things, if it is made a modules, and it breaks for the
>> user, the user gets to keep the pieces. There are potentially some
>> valid scenarios where it is fine to have it as a module. I don't
>> recommend changing this unless is actually starts causing problems.
>
> I assume that you've tested this and it actually makes a difference,
> correct? If so,
>
> Acked-by: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Yes I've tested the entire set on 4 boards / 4 SoCs (A10, A10s, A20 and A31),
and yes it makes a difference.
Regards,
Hans
next prev parent reply other threads:[~2014-11-13 12:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 22:08 [PATCH 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Hans de Goede
[not found] ` <1415830124-28787-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-12 22:08 ` [PATCH 2/4] simplefb: Add support for enumerating simplefb dt nodes in /chosen Hans de Goede
[not found] ` <1415830124-28787-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-12 23:39 ` Julian Calaby
[not found] ` <CAGRGNgW_Q6oghpe5Mw-8aYPVVj1YZ6R3iaqOQzCE9dSD1nYSyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 8:27 ` Hans de Goede
[not found] ` <54646B5B.1070604-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-13 8:34 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVSfYyHc52Tdu_wzb6ZYPzeZtOzweUwADHxiJLypuBQNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 8:40 ` Hans de Goede
[not found] ` <54646E83.9070704-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-13 8:47 ` Julian Calaby
2014-11-13 10:24 ` Grant Likely
2014-11-13 8:15 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWdtxcmDc7fDbQHfVa425sR3MGwJ70cRnh2Wb50iAo2CQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 8:16 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWCF5+N3h890fUpPjAYWBEf6HcFEacz0j5GsLwNoF1Smw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 8:28 ` Hans de Goede
2014-11-12 22:08 ` [PATCH 3/4] simplefb: Change simplefb_init from module_init to fs_initcall Hans de Goede
[not found] ` <1415830124-28787-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-13 8:52 ` Maxime Ripard
2014-11-13 8:58 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXZ4V4GHvyDLOP8FYvPuGArc5G0aO6NCE9FKHT24YRGPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-18 10:19 ` Thierry Reding
2014-11-18 11:01 ` Hans de Goede
[not found] ` <546B26F4.50302-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-18 11:21 ` Thierry Reding
2014-11-18 11:46 ` Hans de Goede
[not found] ` <546B31A7.9020804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-18 12:44 ` Hans de Goede
[not found] ` <546B3F3C.6050202-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-18 15:16 ` Thierry Reding
2014-11-18 15:28 ` Maxime Ripard
2014-11-13 9:24 ` Hans de Goede
[not found] ` <546478B5.2040002-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-13 10:29 ` Grant Likely
[not found] ` <CACxGe6u8B854PEWw8XzwhyX8joMWwOsHOOXtmBmC1TgCGjGtdg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 10:31 ` Grant Likely
[not found] ` <CACxGe6sYD-Ow2wcwAKuXpR3A9VZozo2sgz=eEcWXi5ayKd2jWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 12:01 ` Hans de Goede [this message]
2014-11-13 10:42 ` Maxime Ripard
2014-11-13 16:13 ` Stefan Monnier
[not found] ` <jwvy4rf2i7h.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi-mXXj517/zsQ@public.gmane.org>
2014-11-13 19:04 ` Hans de Goede
2014-11-12 22:08 ` [PATCH 4/4] fbcon: Change fbcon_init " Hans de Goede
2014-11-13 8:38 ` [PATCH 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Geert Uytterhoeven
[not found] ` <CAMuHMdU4YTwyMrD5U1i3DYy=cvpocmzXqajySUfgBKVRhcAJVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 8:43 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54649DA0.8060308@redhat.com \
--to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=libv-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).