From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [RFC v2 2/3] iio: bindings: Add TI afe4403 heart monitor documentation Date: Thu, 13 Nov 2014 06:40:59 -0600 Message-ID: <5464A6DB.3060203@ti.com> References: <1415287106-13491-1-git-send-email-dmurphy@ti.com> <1415287106-13491-2-git-send-email-dmurphy@ti.com> <545E031A.7050302@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <545E031A.7050302-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jonathan Cameron , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, k.wrona-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala List-Id: devicetree@vger.kernel.org Jonathan On 11/08/2014 05:48 AM, Jonathan Cameron wrote: > On 06/11/14 15:18, Dan Murphy wrote: >> Add the TI afe4403 heart monitor device tree >> binding documentation. heart_monitors directory >> created under iio. >> >> Signed-off-by: Dan Murphy > As a device tree binding this MUST go to the device tree list > and maintainers. Cc'd. Yeah forgot to add the list > > I suspect from my review of the driver that there will be a > whole load more stuff to go in here... > >> --- >> >> v2 - Updated per v1 comments - http://marc.info/?l=linux-iio&m=141331404132215&w=2 >> >> .../bindings/iio/heart_monitor/ti_afe4403.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt b/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt >> new file mode 100644 >> index 0000000..cf75b5a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/heart_monitor/ti_afe4403.txt >> @@ -0,0 +1,23 @@ >> +* Texas Instruments - AFE4403 Heart rate and Pulse Oximeter >> + >> +The device consists of a low-noise receiver channel >> +with an integrated analog-to-digital converter (ADC), >> +an LED transmit section, and diagnostics for sensor and LED fault detection. >> + >> +Required properties: >> + - compatible: Must contain "ti,afe4403". >> + - ste-gpio: GPIO for the spi control line >> + - data-ready-gpio: GPIO interrupt when the afe4403 has data > Does this actually need to be a gpio? Doesn't look like it from the driver. > As such should be handled as a generic interrupt both here and in the driver. Well in my setup I connected the data-ready output of the device to a GPIO and I need to tell the driver which GPIO to use. Not sure how else to route the signal from the device to a SoC. > >> + - led-supply: Chip supply to the device >> + >> +Optional properties: >> + - reset-gpio: GPIO used to reset the device via HW >> + >> +Example: >> + >> +&heart_rate { >> + compatible = "ti,afe4403"; >> + ste-gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>; >> + data-ready-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; >> + led-supply = <&vbat>; >> +}; >> -- ------------------ Dan Murphy