devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Roger Quadros <rogerq@ti.com>, tony@atomide.com
Cc: wg@grandegger.com, wsa@the-dreams.de, mugunthanvnm@ti.com,
	george.cherian@ti.com, balbi@ti.com, nsekhar@ti.comnm@ti.com,
	sergei.shtylyov@cogentembedded.com, linux-omap@vger.kernel.org,
	linux-can@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 06/10] ARM: dts: am4372: Add DCAN nodes
Date: Thu, 13 Nov 2014 15:07:52 +0100	[thread overview]
Message-ID: <5464BB38.7020402@pengutronix.de> (raw)
In-Reply-To: <1415881371-4982-7-git-send-email-rogerq@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On 11/13/2014 01:22 PM, Roger Quadros wrote:
> The SoC contains 2 DCAN modules. Add them.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/boot/dts/am4372.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index 899c57c..12fb1db 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -901,6 +901,28 @@
>  			compatible = "mmio-sram";
>  			reg = <0x40300000 0x40000>; /* 256k */
>  		};
> +
> +		dcan0: can@481cc000 {
> +			compatible = "ti,am3352-d_can";

You should add "ti,am4372-d_can" as first compatible here.

> +			ti,hwmods = "d_can0";
> +			clocks = <&dcan0_fck>;
> +			clock-names = "fck";
> +			reg = <0x481cc000 0x2000>;
> +			syscon-raminit = <&am43xx_control_module 0x644 0>;
> +			interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disabled";
> +		};
> +
> +		dcan1: can@481d0000 {
> +			compatible = "ti,am3352-d_can";

Same here.

> +			ti,hwmods = "d_can1";
> +			clocks = <&dcan1_fck>;
> +			clock-names = "fck";
> +			reg = <0x481d0000 0x2000>;
> +			syscon-raminit = <&am43xx_control_module 0x644 1>;
> +			interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disabled";
> +		};
>  	};
>  };
>  
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-11-13 14:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 12:22 [PATCH v4 00/10] ARM: dts: TI: Add CAN support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 01/10] ARM: dts: dra7: Add syscon regmap for CORE CONTROL area Roger Quadros
2014-11-13 12:22 ` [PATCH v4 02/10] ARM: dts: DRA7: Add DCAN nodes Roger Quadros
2014-11-13 12:22 ` [PATCH v4 03/10] ARM: dts: dra7-evm: Add CAN support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 04/10] ARM: dts: dra72-evm: " Roger Quadros
2014-11-13 12:22 ` [PATCH v4 05/10] ARM: dts: am4372: Add control module syscon node Roger Quadros
2014-11-13 12:22 ` [PATCH v4 06/10] ARM: dts: am4372: Add DCAN nodes Roger Quadros
2014-11-13 14:07   ` Marc Kleine-Budde [this message]
2014-11-13 14:40     ` Roger Quadros
2014-11-13 14:44       ` Marc Kleine-Budde
2014-11-13 14:49         ` Roger Quadros
2014-11-13 14:54           ` Marc Kleine-Budde
2014-11-13 17:40             ` Tony Lindgren
2014-11-14 16:22               ` Roger Quadros
2014-11-14 18:07                 ` Tony Lindgren
2014-11-17 13:08   ` [PATCH v5 " Roger Quadros
2014-11-21 23:50     ` Tony Lindgren
2014-11-22  0:08       ` Tony Lindgren
2014-11-24  9:58         ` Roger Quadros
2014-11-24 11:11           ` Roger Quadros
2014-11-24 15:49             ` Tony Lindgren
2014-11-24 16:05               ` Tony Lindgren
2014-11-13 12:22 ` [PATCH v4 07/10] arm: dts: am437x-gp: Add dcan support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 08/10] ARM: dts: am33xx: Add control module syscon node Roger Quadros
2014-11-13 12:22 ` [PATCH v4 09/10] ARM: dts: am33xx: Update DCAN nodes Roger Quadros
2014-11-13 16:03   ` Wolfram Sang
2014-11-13 12:22 ` [PATCH v4 10/10] ARM: dts: am335x-evm: Add DCAN1 details Roger Quadros
2014-11-18 20:42 ` [PATCH v4 00/10] ARM: dts: TI: Add CAN support Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5464BB38.7020402@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=balbi@ti.com \
    --cc=george.cherian@ti.com \
    --cc=mugunthanvnm@ti.com \
    --cc=nsekhar@ti.comnm \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    --cc=wg@grandegger.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).