From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v3 3/4] simplefb: Change simplefb_init from module_init to fs_initcall Date: Thu, 13 Nov 2014 15:47:31 +0100 Message-ID: <5464C483.4040507@redhat.com> References: <1415885645-24613-1-git-send-email-hdegoede@redhat.com> <1415885645-24613-3-git-send-email-hdegoede@redhat.com> <5464C10A.30709@ti.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <5464C10A.30709-l0cyMroinI0@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Tomi Valkeinen Cc: Stephen Warren , Jean-Christophe Plagniol-Villard , Grant Likely , Rob Herring , Luc Verhaegen , Maxime Ripard , David Herrmann , Geert Uytterhoeven , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 11/13/2014 03:32 PM, Tomi Valkeinen wrote: > On 13/11/14 15:34, Hans de Goede wrote: >> One of the reasons for having the simplefb nodes in /chosen, and doing >> explicit enumeration of the nodes there, is too allow enumerating them sooner, >> so that we get a console earlier on. >> >> Doing this earlier then fs_initcall is not useful, since the fb only turns into >> a console when fbcon intializes, which is a fs_initcall too. > > The above text is slightly confusing, as fbcon initializes at > module_init time. You only change it in the next patch. I can move the > fbcon change to be the first patch when applying, if there are no more > versions sent. True, feel free to swap them when applying. Regards, Hans