Re: [PATCH v11 02/12] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

From: Andy Yan <andy.yan@rock-chips.com>
To: Daniel Kurtz <djkurtz@google.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"David Airlie" <airlied@linux.ie>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Yakir Yang" <ykk@rock-chips.com>,
	devel@driverdev.osuosl.org, "Pawel Moll" <pawel.moll@arm.com>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Dave Airlie" <airlied@redhat.com>,
	"Xu Jianqun" <jay.xu@rock-chips.com>,
	"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
	Zubair.Kakakhel@imgtec.com, "Arnd Bergmann" <arnd@arndb.de>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Inki Dae" <inki.dae@samsung.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sean Paul" <seanpaul@chromium.org>,
	rmk+kernel@arm.linux.org.uk,
	"mark.yao@rock-chips.com" <mark.yao@rock-chips.com>,
	fabio.estevam@freescale.com, "Josh Boyer" <jwboyer@redhat.com>
Subject: Re: [PATCH v11 02/12] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter
Date: Mon, 17 Nov 2014 09:35:17 +0800	[thread overview]
Message-ID: <546950D5.20703@rock-chips.com> (raw)
In-Reply-To: <CAGS+omCQ97eo6BhhfCucgeAK8Kq0GtR8jOiv2AF7x=w2d9F8yw@mail.gmail.com>


On 2014年11月15日 13:41, Daniel Kurtz wrote:
> On Fri, Nov 14, 2014 at 9:39 PM, Andy Yan <andy.yan@rock-chips.com> wrote:
>> drm driver may probe before the i2c bus, so the driver should
>> defer probing until it is available
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
>> ---
>>
>> Changes in v11: None
>> Changes in v10: None
>> Changes in v9: None
>> Changes in v8: None
>> Changes in v7: None
>> Changes in v6: None
>> Changes in v5: None
>> Changes in v4:
>> - defer probe ddc i2c adapter
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>>   drivers/staging/imx-drm/imx-hdmi.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/imx-drm/imx-hdmi.c b/drivers/staging/imx-drm/imx-hdmi.c
>> index 79daec4..c2b035a 100644
>> --- a/drivers/staging/imx-drm/imx-hdmi.c
>> +++ b/drivers/staging/imx-drm/imx-hdmi.c
>> @@ -1611,8 +1611,11 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
>>          ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
>>          if (ddc_node) {
>>                  hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
>> -               if (!hdmi->ddc)
>> +               if (!hdmi->ddc) {
>>                          dev_dbg(hdmi->dev, "failed to read ddc node\n");
>> +                       of_node_put(ddc_node);
>> +                       return -EPROBE_DEFER;
>> +               }
> Nit:  You could move "of_node_put()" above "if (!hdmi->ddc)", and not
> need it in two places.
  thanks, I will take your advice
>
> Either way, this one is:
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
>
>>                  of_node_put(ddc_node);
>>          } else {
>> --
>> 1.9.1
>>
>
>


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel