From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 3/5] clk: s2mps11: Add the support for S2MPS13 PMIC clock Date: Tue, 18 Nov 2014 10:06:40 +0900 Message-ID: <546A9BA0.2080406@samsung.com> References: <1416184980-532-1-git-send-email-cw00.choi@samsung.com> <1416184980-532-4-git-send-email-cw00.choi@samsung.com> <5469CAF9.6020700@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <5469CAF9.6020700-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?S3J6eXN6dG9mIEtvesWCb3dza2k=?= Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sbkim73-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, geunsik.lim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 11/17/2014 07:16 PM, Krzysztof Koz=C5=82owski wrote: > On 17.11.2014 01:42, Chanwoo Choi wrote: >> This patch adds the support for S2MPS13 PMIC clock which is same wit= h existing >> S2MPS14 RTC IP. But, S2MPS13 uses all of clocks (32khz_{ap|bt|cp}). >> >> Cc: Mike Turquette >> Signed-off-by: Chanwoo Choi >> --- >> drivers/clk/clk-s2mps11.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c >> index b7797fb..7bb13af 100644 >> --- a/drivers/clk/clk-s2mps11.c >> +++ b/drivers/clk/clk-s2mps11.c >> @@ -23,6 +23,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -120,6 +121,24 @@ static struct clk_init_data s2mps11_clks_init[S= 2MPS11_CLKS_NUM] =3D { >> }, >> }; >> =20 >> +static struct clk_init_data s2mps13_clks_init[S2MPS11_CLKS_NUM] =3D= { >> + [S2MPS11_CLK_AP] =3D { >> + .name =3D "s2mps13_ap", >> + .ops =3D &s2mps11_clk_ops, >> + .flags =3D CLK_IS_ROOT, >> + }, >> + [S2MPS11_CLK_CP] =3D { >> + .name =3D "s2mps13_cp", >> + .ops =3D &s2mps11_clk_ops, >> .flags =3D CLK_IS_ROOT, >=20 > The patch looks corrupted here. Missing '+'? You are right. It is my mistake. I will fix it. >=20 > Rest looks fine. > Reviewed-by: Krzysztof Kozlowski Thanks for your review. Best Regards, Chanwoo Choi >=20 > Best regards, > Krzysztof >=20 >=20 >> + }, >> + [S2MPS11_CLK_BT] =3D { >> + .name =3D "s2mps13_bt", >> + .ops =3D &s2mps11_clk_ops, >> + .flags =3D CLK_IS_ROOT, >> + }, >> +}; >> + >> static struct clk_init_data s2mps14_clks_init[S2MPS11_CLKS_NUM] =3D= { >> [S2MPS11_CLK_AP] =3D { >> .name =3D "s2mps14_ap", >> @@ -184,6 +203,10 @@ static int s2mps11_clk_probe(struct platform_de= vice *pdev) >> s2mps11_reg =3D S2MPS11_REG_RTC_CTRL; >> clks_init =3D s2mps11_clks_init; >> break; >> + case S2MPS13X: >> + s2mps11_reg =3D S2MPS13_REG_RTCCTRL; >> + clks_init =3D s2mps13_clks_init; >> + break; >> case S2MPS14X: >> s2mps11_reg =3D S2MPS14_REG_RTCCTRL; >> clks_init =3D s2mps14_clks_init; >> @@ -279,6 +302,7 @@ static int s2mps11_clk_remove(struct platform_de= vice *pdev) >> =20 >> static const struct platform_device_id s2mps11_clk_id[] =3D { >> { "s2mps11-clk", S2MPS11X}, >> + { "s2mps13-clk", S2MPS13X}, >> { "s2mps14-clk", S2MPS14X}, >> { "s5m8767-clk", S5M8767X}, >> { }, >> >=20 >=20 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html