From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Roger Quadros <rogerq@ti.com>, tony@atomide.com
Cc: wg@grandegger.com, wsa@the-dreams.de, mugunthanvnm@ti.com,
george.cherian@ti.com, balbi@ti.com, nsekhar@ti.comnm@ti.com,
sergei.shtylyov@cogentembedded.com, linux-omap@vger.kernel.org,
linux-can@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 00/10] ARM: dts: TI: Add CAN support
Date: Tue, 18 Nov 2014 21:42:28 +0100 [thread overview]
Message-ID: <546BAF34.1020409@pengutronix.de> (raw)
In-Reply-To: <1415881371-4982-1-git-send-email-rogerq@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On 11/13/2014 01:22 PM, Roger Quadros wrote:
> Hi Tony,
>
> These patches add CAN support for am33xx, am43xx and dra7 platforms.
> They can go in independent of [1] but depend on [1] for functionality.
>
> Tested on am335x-evm, am437x-gp-evm and dra7-evm.
>
> NOTE:
> - for DCAN to work on DRA7 we need this patch to keep the CAN PHY powered.
> https://lkml.org/lkml/2014/10/21/484
>
> - on DRA7 there is another issue which causes undesired behaviour if WKUPAON and
> L4CFG clock domains are allowed to HW_AUTO. Undesired behaviour is in the form
> of DCAN1 module being stuck-in-transition when disabled and RAMINIT-done bit
> not getting set as part of RAMINIT mechanism. To address these issues there is a patch
> to prevent these clockdomains from HW_AUTO.
> https://github.com/rogerq/linux/commit/31d6da939dbbaf8ea2ab96ca5680b81cd5607e51
> Even without this second patch DCAN seems to work.
FWIW:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
I've send a pull request with the CAN driver changes to David Miller
yesterday, the code is supposed to hit mainline in v3.19.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-11-18 20:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 12:22 [PATCH v4 00/10] ARM: dts: TI: Add CAN support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 01/10] ARM: dts: dra7: Add syscon regmap for CORE CONTROL area Roger Quadros
2014-11-13 12:22 ` [PATCH v4 02/10] ARM: dts: DRA7: Add DCAN nodes Roger Quadros
2014-11-13 12:22 ` [PATCH v4 03/10] ARM: dts: dra7-evm: Add CAN support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 04/10] ARM: dts: dra72-evm: " Roger Quadros
2014-11-13 12:22 ` [PATCH v4 05/10] ARM: dts: am4372: Add control module syscon node Roger Quadros
2014-11-13 12:22 ` [PATCH v4 06/10] ARM: dts: am4372: Add DCAN nodes Roger Quadros
2014-11-13 14:07 ` Marc Kleine-Budde
2014-11-13 14:40 ` Roger Quadros
2014-11-13 14:44 ` Marc Kleine-Budde
2014-11-13 14:49 ` Roger Quadros
2014-11-13 14:54 ` Marc Kleine-Budde
2014-11-13 17:40 ` Tony Lindgren
2014-11-14 16:22 ` Roger Quadros
2014-11-14 18:07 ` Tony Lindgren
2014-11-17 13:08 ` [PATCH v5 " Roger Quadros
2014-11-21 23:50 ` Tony Lindgren
2014-11-22 0:08 ` Tony Lindgren
2014-11-24 9:58 ` Roger Quadros
2014-11-24 11:11 ` Roger Quadros
2014-11-24 15:49 ` Tony Lindgren
2014-11-24 16:05 ` Tony Lindgren
2014-11-13 12:22 ` [PATCH v4 07/10] arm: dts: am437x-gp: Add dcan support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 08/10] ARM: dts: am33xx: Add control module syscon node Roger Quadros
2014-11-13 12:22 ` [PATCH v4 09/10] ARM: dts: am33xx: Update DCAN nodes Roger Quadros
2014-11-13 16:03 ` Wolfram Sang
2014-11-13 12:22 ` [PATCH v4 10/10] ARM: dts: am335x-evm: Add DCAN1 details Roger Quadros
2014-11-18 20:42 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546BAF34.1020409@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.comnm \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).