From: Caesar Wang <caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
"Kever Yang" <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"Eddie Cai" <cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"ZhenFu Fang" <fzf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Chris Zhong"
<chris.zhong-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"Sonny Rao" <sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: fix PWM clock found on RK3288 Socs
Date: Wed, 19 Nov 2014 18:27:45 +0800 [thread overview]
Message-ID: <546C70A1.9090707@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=W+WU3j7OWKTxtGUv1Jt7qPesGXSOsoM=bsD5C15jttvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Doug,
在 2014/11/19 13:14, Doug Anderson 写道:
> Caesar,
>
> On Tue, Nov 18, 2014 at 7:25 PM, Caesar Wang <caesar.wang@rock-chips.com> wrote:
>> We use the new PWM IP on RK3288,but the PWM's clock indeed incorrect.
>>
>> Signed-off-by: Caesar Wang <caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>> ---
>> arch/arm/boot/dts/rk3288.dtsi | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
> Right, I reported this when Kever was doing his "unused clocks" patch.
> That's why this clock is currently "ignore unused".
>
> ...but though your change is right, I'd rather your change doesn't
> land quite yet. It totally wrecks havoc with the PWM regulator used
> on many rk3288 boards and will glitch the main "logic" voltage at
> bootup. I have some patches that are MASSIVELY WIP:
>
> https://chromium-review.googlesource.com/230640
> WIP: regulator: pwm: Tell regulator framework that we can't turn off
>
> https://chromium-review.googlesource.com/230641
> WIP: PWM: handle the fact that firmware might have left us enabled
>
> https://chromium-review.googlesource.com/230642
> WIP: pwm-regulator stuff
>
> I think that last one might blow up into several patches. We need to
> solve the problems from those patches before yours can really land.
>
>
> It's pretty high on my list to finish the above patches, but right now
> suspend/resume issues are higher priority so it's a bit stalled... If
> someone wants to hijack any of the above patches please let me know--I
> won't be offended.
OK,I see.
> -Doug
>
>
>
--
Best regards,
Caesar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-11-19 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 3:25 [PATCH] ARM: dts: fix PWM clock found on RK3288 Socs Caesar Wang
2014-11-19 5:14 ` Doug Anderson
[not found] ` <CAD=FV=W+WU3j7OWKTxtGUv1Jt7qPesGXSOsoM=bsD5C15jttvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-19 10:27 ` Caesar Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546C70A1.9090707@rock-chips.com \
--to=caesar.wang-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=chris.zhong-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=fzf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).