From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCHv5 1/1] thermal: of: improve of-thermal sensor registration API Date: Thu, 20 Nov 2014 06:23:29 -0800 Message-ID: <546DF961.3050509@roeck-us.net> References: <1416492733-1624-1-git-send-email-edubezval@gmail.com> <1416492733-1624-2-git-send-email-edubezval@gmail.com> <20141120141806.GA1746@developer> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141120141806.GA1746@developer> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eduardo Valentin , Linux PM Cc: Caesar Wang , Wei Ni , Lukasz Majewski , Mikko Perttunen , Alexandre Courbot , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant Likely , Jean Delvare , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, Rob Herring , Stephen Warren , Thierry Reding , Zhang Rui List-Id: devicetree@vger.kernel.org On 11/20/2014 06:18 AM, Eduardo Valentin wrote: > Hi Guenter, > > On Thu, Nov 20, 2014 at 10:12:13AM -0400, Eduardo Valentin wrote: >> Different drivers request API extensions in of-thermal. For this reason, >> additional callbacks are required to fit the new drivers needs. >> >> The current API implementation expects the registering sensor driver >> to provide a get_temp and get_trend callbacks as function parameters. >> As the amount of callbacks is growing, this patch changes the existing >> implementation to use a .ops field to hold all the of thermal callbacks >> to sensor drivers. >> >> This patch also changes the existing of-thermal users to fit the new >> API design. No functional change is introduced in this patch. >> >> Cc: Alexandre Courbot >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Cc: Grant Likely >> Cc: Guenter Roeck >> Cc: Jean Delvare >> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Cc: lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org >> Cc: Rob Herring >> Cc: Stephen Warren >> Cc: Thierry Reding >> Cc: Zhang Rui >> Tested-by: Mikko Perttunen >> Reviewed-by: Mikko Perttunen >> Reviewed-by: Alexandre Courbot >> Reviewed-by: Lukasz Majewski >> Signed-off-by: Eduardo Valentin >> --- >> drivers/hwmon/lm75.c | 9 +++-- >> drivers/hwmon/ntc_thermistor.c | 6 +++- >> drivers/hwmon/tmp102.c | 6 +++- > > Do you have objections if I queue this one for 3.19? > No. Guenter