From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH] Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt Date: Thu, 20 Nov 2014 15:48:26 +0100 Message-ID: <546DFF3A.7020702@samsung.com> References: <20141120131713.GC27527@amd> <546DEEC3.7090508@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <546DEEC3.7090508@samsung.com> Sender: linux-leds-owner@vger.kernel.org To: Pavel Machek Cc: sakari.ailus@iki.fi, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rob@landley.net List-Id: devicetree@vger.kernel.org On 11/20/2014 02:38 PM, Jacek Anaszewski wrote: > Hi Pavel, > > On 11/20/2014 02:17 PM, Pavel Machek wrote: >> >> Add attributes neccessary for LED flashes to >> devicetree/bindings/leds/common.txt . >> >> This will allow me to add device tree support for adp1653 i2c flash >> LED driver, and allow Jacek Anaszewski to add support for more LED >> drivers.. >> >> Signed-off-by: Pavel Machek >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt >> b/Documentation/devicetree/bindings/leds/common.txt >> index 2d88816..e9acbbc 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -14,6 +14,15 @@ Optional properties for child nodes: >> "ide-disk" - LED indicates disk activity >> "timer" - LED flashes at a fixed, configurable rate >> >> +- max-microamp : maximum intensity in microamperes of the LED >> + (torch LED for flash devices) >> +- flash-max-microamp : maximum intensity in microamperes of the >> + flash LED; it is mandatory if the LED should >> + support the flash mode >> +- flash-timeout-microsec : timeout in microseconds after which the flash >> + LED is turned off >> + >> + >> Examples: >> >> system-status { >> @@ -21,3 +30,10 @@ system-status { >> linux,default-trigger = "heartbeat"; >> ... >> }; >> + >> +camera-flash { >> + label = "Flash"; >> + max-microamp = <50000>; >> + flash-max-microamp = <320000>; >> + flash-timeout-microsec = <500000>; >> +} >> > > Why did you omit indicator-pattern? Actually, we've agreed with Sakari that we can handle indicator-pattern later. I would remove references to you, me and adp1653 driver from the commit message and mention that this modifications adjust the led common bindings to the LED Flash class that is to be added. Regards, Jacek