From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B0733446AA; Mon, 15 Dec 2025 19:33:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765827209; cv=none; b=VPWM7ZZ1hbU9ZFYd4/7vDXTNdPWKeEI4jCEia4qOYKRMiuRsnX3vD/rlckz5qIxB+PdVInnHkGkykb4el6qZlH5f7LzwE9xj0aQbZupvlXJ2u98hPZXI/VEKGN6mzLp9a/+t0y6dZX343q+k6m/E1E52RlSA8e04DLMOyytG9SQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765827209; c=relaxed/simple; bh=Xf/Uivn2/05IFaA/e+fqhQihwVLhOLhR1m30cTTyHno=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GImgvA0bGBZDKn5XsEqk0UDL3JNJaKEZBzK4u16r465iNtgRpaaZBYDsSUj6SYT2ZlRYOn00hs7znF/CMFqx97jhOYk+9JSab2IBDTPIicHgadso6LeUqmXUzcuy1Iyr5iui3uzmrmPtYer8BRdOp5MCHqzzUhKufC6wyjtxG7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TDSd2bDG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TDSd2bDG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73F21C4CEF5; Mon, 15 Dec 2025 19:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765827208; bh=Xf/Uivn2/05IFaA/e+fqhQihwVLhOLhR1m30cTTyHno=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TDSd2bDGVVxpTStolPf4XfKM5vsnraj4PlGN9K/1MRm4lr5MsSOYDxeLm1lh8FMR/ n2bXpNs3Dx8k0brZP/eDsSl+TcSW68ACV8RXbJfSN/BOSoH7ib2PTvwFqxpauuf1U8 dQ7L/madDBUOH9aWSnyI6qzDEr3SQDSWVD1xW74YPKp9arB+rMGVmLPwP9UZRGTIgo Ep979uz3mdtzNrV9ku/wLODNYc9l41NpX88GmULxxz2LFKJPQ5mLBHcrLPKbrr1kQ4 k2VfmcLKjLcl2i81hlAxz5UgLerJM3kAl7xSY+lpoN+zSNrYUTlAQPGXkwpbTspKeU iJoSECfAkuQrQ== Message-ID: <546ff0cb-a3a2-4fa4-a78b-79c923ed7765@kernel.org> Date: Mon, 15 Dec 2025 20:33:24 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10) To: David Heidelberg , Lukas Timmermann , Alim Akhtar , Rob Herring , Conor Dooley , Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Alexandre Marquet References: <20251215-lat3st-staging-v3-0-2e4914b64dd8@timmermann.space> <20251215-lat3st-staging-v3-2-2e4914b64dd8@timmermann.space> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/12/2025 19:53, David Heidelberg wrote: > Hello Lucas, > > thanks for the sending Nexus 10 upstream, see few nitpicks below: > > On 15/12/2025 16:05, Lukas Timmermann wrote: >> From: Alexandre Marquet >> >> Manta is the code name for Google Nexus 10, and was manufactured by >> Samsung with their Exynos5250 SoC. >> This patch adds initial device-tree file for this board. >> >> Signed-off-by: Alexandre Marquet >> Co-developed-by: Lukas Timmermann >> Signed-off-by: Lukas Timmermann >> --- >> arch/arm/boot/dts/samsung/Makefile | 1 + >> arch/arm/boot/dts/samsung/exynos5250-manta.dts | 511 +++++++++++++++++++++++++ >> 2 files changed, 512 insertions(+) >> >> diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile >> index 7becf36656b1..e0143ee8c82d 100644 >> --- a/arch/arm/boot/dts/samsung/Makefile >> +++ b/arch/arm/boot/dts/samsung/Makefile >> @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ >> exynos4412-trats2.dtb >> dtb-$(CONFIG_ARCH_EXYNOS5) += \ >> exynos5250-arndale.dtb \ >> + exynos5250-manta.dtb \ >> exynos5250-smdk5250.dtb \ >> exynos5250-snow.dtb \ >> exynos5250-snow-rev5.dtb \ >> diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-manta.dts >> new file mode 100644 >> index 000000000000..0f006590576c >> --- /dev/null >> +++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts >> @@ -0,0 +1,511 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > you could use here modern SPDX I guess (GPL-2.0-only) > >> +/* >> + * Google Manta (Nexus 10) board device tree source >> + * >> + * Copyright (c) 2023-2025 Alexandre Marquet >> + * Copyright (c) 2025 Lukas Timmermann >> + */ >> + >> +/dts-v1/; >> +#include >> +#include >> +#include >> +#include >> +#include "exynos-pinctrl.h" >> +#include "exynos5250.dtsi" >> +#include "exynos-mfc-reserved-memory.dtsi" >> + >> +/ { >> + model = "Google Nexus 10"; >> + compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5"; >> + >> + aliases { >> + mmc0 = &mmc_0; /* eMMC */ >> + mmc1 = &mmc_1; /* WiFi */ >> + }; >> + >> + bmp180_vdda_reg: regulator-bmp180-vdda { >> + compatible = "regulator-fixed"; >> + regulator-name = "BMP180_VDDA"; >> + }; > something-something-regulator (all occurences within the DTS) > I don't understand this suggestion. >> + >> + bmp180_vddd_reg: regulator-bmp180-vddd { >> + compatible = "regulator-fixed"; >> + regulator-name = "BMP180_VDDD"; >> + }; >> +}; >> + >> +&clock { >> + assigned-clocks = <&clock CLK_FOUT_APLL>; >> + assigned-clock-rates = <1000000000>; >> +}; >> + >> +&cpu0 { >> + cpu0-supply = <&buck2_reg>; >> +}; >> + >> +&ehci { >> + status = "disabled"; >> +}; >> + >> +&i2c_0 { >> + status = "okay"; > > status should be before first sub-node (none in this case), with > preceding newline, please change all occurences > Well yeah, but do you have actually any comment pointing real issues? Best regards, Krzysztof