* FIX ME in xsysace.c
@ 2014-11-24 4:19 nick
[not found] ` <5472B1D6.7080805-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: nick @ 2014-11-24 4:19 UTC (permalink / raw)
To: michal.simek
Cc: devicetree, linux-kernel, robh+dt, soren.brinkmann, grant.likely,
linux-arm-kernel
Greetings Michal and others,
I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated.
Cheers
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <5472B1D6.7080805-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: FIX ME in xsysace.c [not found] ` <5472B1D6.7080805-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-11-24 7:47 ` Michal Simek 2014-11-24 11:28 ` nick 0 siblings, 1 reply; 4+ messages in thread From: Michal Simek @ 2014-11-24 7:47 UTC (permalink / raw) To: nick, michal.simek-gjFFaj9aHVfQT0dZR+AlfA Cc: soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA, grant.likely-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA Hi, On 11/24/2014 05:19 AM, nick wrote: > Greetings Michal and others, > I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated. I think that will be the best to c&p that fixme which you are talking about. Definitely feel free to fix whatever fixme is there and send the patch for fixing it. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: FIX ME in xsysace.c 2014-11-24 7:47 ` Michal Simek @ 2014-11-24 11:28 ` nick [not found] ` <54731648.8010006-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: nick @ 2014-11-24 11:28 UTC (permalink / raw) To: Michal Simek Cc: devicetree, linux-kernel, robh+dt, soren.brinkmann, grant.likely, linux-arm-kernel On 14-11-24 02:47 AM, Michal Simek wrote: > Hi, > > On 11/24/2014 05:19 AM, nick wrote: >> Greetings Michal and others, >> I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated. > > I think that will be the best to c&p that fixme which you are talking about. > Definitely feel free to fix whatever fixme is there and send the patch > for fixing it. > > Thanks, > Michal > Here is the fix me. int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ Cheers Nick ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <54731648.8010006-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: FIX ME in xsysace.c [not found] ` <54731648.8010006-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-11-24 14:32 ` Michal Simek 0 siblings, 0 replies; 4+ messages in thread From: Michal Simek @ 2014-11-24 14:32 UTC (permalink / raw) To: nick, Michal Simek Cc: soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA, grant.likely-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA Hi, On 11/24/2014 12:28 PM, nick wrote: > > > On 14-11-24 02:47 AM, Michal Simek wrote: >> Hi, >> >> On 11/24/2014 05:19 AM, nick wrote: >>> Greetings Michal and others, >>> I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated. >> >> I think that will be the best to c&p that fixme which you are talking about. >> Definitely feel free to fix whatever fixme is there and send the patch >> for fixing it. >> >> Thanks, >> Michal >> > Here is the fix me. > int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ FIXME is totally bogus and should be removed. I expect you want to use 8bit bus mode which driver itself supports. This line is just default setup to 16bit mode. If you add 8-bit property to dts you are there. if (of_find_property(dev->dev.of_node, "8-bit", NULL)) bus_width = ACE_BUS_WIDTH_8; Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-24 14:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 4:19 FIX ME in xsysace.c nick
[not found] ` <5472B1D6.7080805-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-24 7:47 ` Michal Simek
2014-11-24 11:28 ` nick
[not found] ` <54731648.8010006-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-24 14:32 ` Michal Simek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).