From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Marek Belisko <marek@goldelico.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
grant.likely@linaro.org, devicetree@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-fbdev@vger.kernel.org, gta04-owner@goldelico.com
Subject: Re: [PATCH v2 1/5] video: omapdss: Add opa362 driver
Date: Mon, 24 Nov 2014 13:47:49 +0200 [thread overview]
Message-ID: <54731AE5.7080607@ti.com> (raw)
In-Reply-To: <BF6765C1-8D5C-4ABA-8796-195058C82E17@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On 19/11/14 17:10, Dr. H. Nikolaus Schaller wrote:
>> You don't need to ask. The connector calls invert_vid_out_polarity
>> before enabling the output.
>
> Unfortunately it doesn’t. At least not always.
>
> It does only for pdata systems but not for DT based systems:
>
> if (!ddata->dev->of_node) {
> in->ops.atv->set_type(in, ddata->connector_type);
> in->ops.atv->invert_vid_out_polarity(in,
> ddata->invert_polarity);
> }
>
> Not calling is in our case different from calling with ddata->invert_polarity == 0.
Ah, sorry, my mistake. I should've read the code more carefully =).
So, with DT only approach, those calls above are not supported. If you
make the OPA driver DT only, you can remove those functions.
You only need to set the invert-polarity property in the venc DT node.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-24 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 22:10 [PATCH v2 0/5] omapdss: Add video output support for gta04 board Marek Belisko
2014-11-12 22:10 ` [PATCH v2 1/5] video: omapdss: Add opa362 driver Marek Belisko
[not found] ` <1415830247-31633-2-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2014-11-13 11:51 ` Tomi Valkeinen
[not found] ` <54649B43.1000801-l0cyMroinI0@public.gmane.org>
2014-11-13 16:25 ` Dr. H. Nikolaus Schaller
[not found] ` <9FD016B8-4EA2-4A0D-B790-6494AB449B31-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2014-11-13 16:41 ` Tomi Valkeinen
2014-11-19 15:10 ` Dr. H. Nikolaus Schaller
2014-11-24 11:47 ` Tomi Valkeinen [this message]
2014-11-12 22:10 ` [PATCH v2 2/5] Documentation: DT: Add documentation for ti, opa362 bindings Marek Belisko
2014-11-12 22:10 ` [PATCH v2 3/5] arm: dts: omap3-gta04: Add handling for tv output Marek Belisko
2014-11-12 22:10 ` [PATCH v2 4/5] arm: dts: omap3: Add definition for devconf1 register Marek Belisko
[not found] ` <1415830247-31633-1-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2014-11-12 22:10 ` [PATCH v2 5/5] arm: dts: omap3-gta04: Add static configuration " Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54731AE5.7080607@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gta04-owner@goldelico.com \
--cc=hns@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).