* [PATCH 0/2] Increase the maximum cpu frequency of rk3288
@ 2014-11-25 9:37 Chris Zhong
2014-11-25 9:37 ` [PATCH 1/2] ARM: dts: rockchip: change the max voltage of cpu to 1.4v Chris Zhong
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Zhong @ 2014-11-25 9:37 UTC (permalink / raw)
To: heiko, dianders
Cc: Linus Walleij, linux-rockchip, Chris Zhong, Russell King,
devicetree, Kumar Gala, linux-kernel, Ian Campbell, Rob Herring,
Pawel Moll, Mark Rutland, linux-arm-kernel
The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need set
to 1.4v. I've tested these patches on rk3288 evb board.
Chris Zhong (2):
ARM: dts: rockchip: change the max voltage of cpu to 1.4v
ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz
arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +-
arch/arm/boot/dts/rk3288.dtsi | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] ARM: dts: rockchip: change the max voltage of cpu to 1.4v 2014-11-25 9:37 [PATCH 0/2] Increase the maximum cpu frequency of rk3288 Chris Zhong @ 2014-11-25 9:37 ` Chris Zhong 2014-11-25 9:37 ` [PATCH 2/2] ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz Chris Zhong 2014-11-25 16:13 ` [PATCH 0/2] Increase the maximum cpu frequency of rk3288 Kever Yang 2 siblings, 0 replies; 6+ messages in thread From: Chris Zhong @ 2014-11-25 9:37 UTC (permalink / raw) To: heiko, dianders Cc: Linus Walleij, linux-rockchip, Chris Zhong, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel, devicetree, linux-kernel If the cpu frequencies up to 1.8Ghz, we need set the vdd_cpu to 1.4v. Signed-off-by: Chris Zhong <zyw@rock-chips.com> --- arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts index d8c775e6..d4f74dd 100644 --- a/arch/arm/boot/dts/rk3288-evb-rk808.dts +++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts @@ -48,7 +48,7 @@ regulator-always-on; regulator-boot-on; regulator-min-microvolt = <750000>; - regulator-max-microvolt = <1350000>; + regulator-max-microvolt = <1400000>; regulator-name = "vdd_arm"; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz 2014-11-25 9:37 [PATCH 0/2] Increase the maximum cpu frequency of rk3288 Chris Zhong 2014-11-25 9:37 ` [PATCH 1/2] ARM: dts: rockchip: change the max voltage of cpu to 1.4v Chris Zhong @ 2014-11-25 9:37 ` Chris Zhong 2014-11-25 16:13 ` [PATCH 0/2] Increase the maximum cpu frequency of rk3288 Kever Yang 2 siblings, 0 replies; 6+ messages in thread From: Chris Zhong @ 2014-11-25 9:37 UTC (permalink / raw) To: heiko, dianders Cc: Linus Walleij, linux-rockchip, Chris Zhong, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel, devicetree, linux-kernel The maximum cpu frequency of rk3288 can up to 1.8Ghz, and it need to set the vdd_cpu to 1.4v correspondingly. Signed-off-by: Chris Zhong <zyw@rock-chips.com> --- arch/arm/boot/dts/rk3288.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 0f50d5d..4f77a05 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -56,8 +56,10 @@ resets = <&cru SRST_CORE0>; operating-points = < /* KHz uV */ - 1608000 1350000 - 1512000 1300000 + 1800000 1400000 + 1704000 1350000 + 1608000 1300000 + 1512000 1250000 1416000 1200000 1200000 1100000 1008000 1050000 -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Increase the maximum cpu frequency of rk3288 2014-11-25 9:37 [PATCH 0/2] Increase the maximum cpu frequency of rk3288 Chris Zhong 2014-11-25 9:37 ` [PATCH 1/2] ARM: dts: rockchip: change the max voltage of cpu to 1.4v Chris Zhong 2014-11-25 9:37 ` [PATCH 2/2] ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz Chris Zhong @ 2014-11-25 16:13 ` Kever Yang 2014-11-25 16:23 ` Heiko Stübner 2 siblings, 1 reply; 6+ messages in thread From: Kever Yang @ 2014-11-25 16:13 UTC (permalink / raw) To: Chris Zhong, heiko, dianders Cc: Mark Rutland, devicetree, Russell King, Pawel Moll, Ian Campbell, Linus Walleij, linux-kernel, linux-rockchip, Rob Herring, Kumar Gala, linux-arm-kernel Hi Chris, On 11/25/2014 05:37 PM, Chris Zhong wrote: > The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need set > to 1.4v. I've tested these patches on rk3288 evb board. I'm not sure why you need this patch, I think we have a discuss for the cpu operating point before. In this case: 1. rk3288.dtsi is for all the rk3288 Soc based system, you may need a separate opp table in rk3288-evb-rk808.dts; 2. 1.4V may beyond the supported voltage range too much, and it's not a good idea to add it to rk3288.dtsi as a safe voltage. 3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz? - Kever > > > Chris Zhong (2): > ARM: dts: rockchip: change the max voltage of cpu to 1.4v > ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz > > arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +- > arch/arm/boot/dts/rk3288.dtsi | 6 ++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Increase the maximum cpu frequency of rk3288 2014-11-25 16:13 ` [PATCH 0/2] Increase the maximum cpu frequency of rk3288 Kever Yang @ 2014-11-25 16:23 ` Heiko Stübner 2014-11-25 17:37 ` Doug Anderson 0 siblings, 1 reply; 6+ messages in thread From: Heiko Stübner @ 2014-11-25 16:23 UTC (permalink / raw) To: Kever Yang Cc: Chris Zhong, dianders, Mark Rutland, devicetree, Russell King, Pawel Moll, Ian Campbell, Linus Walleij, linux-kernel, linux-rockchip, Rob Herring, Kumar Gala, linux-arm-kernel Hi Chris, Kever, Am Mittwoch, 26. November 2014, 00:13:40 schrieb Kever Yang: > On 11/25/2014 05:37 PM, Chris Zhong wrote: > > The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need > > set to 1.4v. I've tested these patches on rk3288 evb board. > > I'm not sure why you need this patch, I think we have a discuss > for the cpu operating point before. > In this case: > 1. rk3288.dtsi is for all the rk3288 Soc based system, you may need > a separate opp table in rk3288-evb-rk808.dts; > 2. 1.4V may beyond the supported voltage range too much, > and it's not a good idea to add it to rk3288.dtsi as a safe voltage. > 3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz? That is how I remember it as well ... the default opp table is supposed to contain only the safest of values, while individual boards can then increase those in conjunction with their thermal design. As the evb itself does only have the naked soc without any heat-sink or similar, I'm not even sure if these additional frequencies should be enabled there at all. Heiko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Increase the maximum cpu frequency of rk3288 2014-11-25 16:23 ` Heiko Stübner @ 2014-11-25 17:37 ` Doug Anderson 0 siblings, 0 replies; 6+ messages in thread From: Doug Anderson @ 2014-11-25 17:37 UTC (permalink / raw) To: Heiko Stübner Cc: Kever Yang, Chris Zhong, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King, Pawel Moll, Ian Campbell, Linus Walleij, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, open list:ARM/Rockchip SoC..., Rob Herring, Kumar Gala, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Hi, On Tue, Nov 25, 2014 at 8:23 AM, Heiko Stübner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> wrote: > Hi Chris, Kever, > > Am Mittwoch, 26. November 2014, 00:13:40 schrieb Kever Yang: >> On 11/25/2014 05:37 PM, Chris Zhong wrote: >> > The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need >> > set to 1.4v. I've tested these patches on rk3288 evb board. >> >> I'm not sure why you need this patch, I think we have a discuss >> for the cpu operating point before. >> In this case: >> 1. rk3288.dtsi is for all the rk3288 Soc based system, you may need >> a separate opp table in rk3288-evb-rk808.dts; >> 2. 1.4V may beyond the supported voltage range too much, >> and it's not a good idea to add it to rk3288.dtsi as a safe voltage. >> 3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz? > > That is how I remember it as well ... the default opp table is supposed to > contain only the safest of values, while individual boards can then increase > those in conjunction with their thermal design. > > As the evb itself does only have the naked soc without any heat-sink or > similar, I'm not even sure if these additional frequencies should be enabled > there at all. I'm not sure that the story from Rockchip is all straight about all of this stuff, but I will say that: * The latest datasheet I have (1.3) shows the maximum CPU frequency as 1.8GHz. It shows the maximum CPU voltage as TBD. That indicates that rk3288.dtsi ought to list 1.8GHz values. * The 1.4V number comes from folks at Rockchip. Please check with Jianqun Xu and Eddie Cai to check. If 1.4V is not safe we certainly shouldn't use it. I believe they have seen boards where 1.8GHz needed 1.4V to be reliable. Either the SoCs on these boards are out of spec or 1.4V is needed. * If you're worried about heat we should make sure that all the thermal changes are in. That will still let you run at 1.8GHz temporarily. You can put a heatsync on and run faster. * These numbers are still conservative as far as I understand. For instance on rk3288-pinky 1.8GHz is a full .1V lower at 1.3V. * If EVB was shipped with pre-production chips that can't support high voltages or frequencies, it should override the table to remove the high frequencies. However, if the table that Chris submitted is generally correct (and conservative) for rk3288 devices that are expected in real products then it seems like it ought to land in rk3288.dtsi. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-25 17:37 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-25 9:37 [PATCH 0/2] Increase the maximum cpu frequency of rk3288 Chris Zhong 2014-11-25 9:37 ` [PATCH 1/2] ARM: dts: rockchip: change the max voltage of cpu to 1.4v Chris Zhong 2014-11-25 9:37 ` [PATCH 2/2] ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz Chris Zhong 2014-11-25 16:13 ` [PATCH 0/2] Increase the maximum cpu frequency of rk3288 Kever Yang 2014-11-25 16:23 ` Heiko Stübner 2014-11-25 17:37 ` Doug Anderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).