From: Michal Marek <mmarek@suse.cz>
To: Jason Cooper <jason@lakedaemon.net>,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: kbuild: Fix forced rebuild after 'make dtbs'
Date: Tue, 25 Nov 2014 22:41:35 +0100 [thread overview]
Message-ID: <5474F78F.2060906@suse.cz> (raw)
In-Reply-To: <1414961549-31666-1-git-send-email-jason@lakedaemon.net>
Dne 2.11.2014 v 21:52 Jason Cooper napsal(a):
> After this patch:
>
> f4d4ffc03efc kbuild: dtbs_install: new make target
>
> was added the kernel tree, Linus Walleij noticed that 'make dtbs' forced
> a following 'make zImage' to rebuild the entire tree, even though
> nothing had changed. His report:
>
> After this patch a while back I have observed the following behaviour
> of the kernel build:
>
> make zImage
> make zImage
> -> incremental build, just relink
>
> make zImage
> make dtbs
> make zImage
> -> The whole kernel gets rebuilt
>
> So now if I happen to recompile my device trees, I suddenly want
> the entire zImage to be rebuilt to? It's by definition not changes
> that affect the kernel build :-(
>
> I noticed this because my build scripts calls make dtbs && make
> zImage, and started to rebuild absolutely everything all the time.
>
> To fix this, we make only the dtbs_install target depend on the prepare
> target. It's needed to make sure KERNELVERSION is calculated prior to
> installing.
If a mere 'make prepare' causes a rebuild of the whole kernel, then
there is something fishy in the ARM Makefiles. However, if you only need
the KERNELRELEASE variable, then you do not need to depend on prepare.
The main Makefile makes sure that silentoldconfig is ran and therefore
KERNELRELEASE set for all targets except make *config.
Michal
next prev parent reply other threads:[~2014-11-25 21:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 10:15 [git pull] Devicetree changes for v3.15 Grant Likely
2014-04-01 19:42 ` Paul Bolle
2014-04-01 20:18 ` Rob Herring
[not found] ` <CAL_JsqKyLPa9PhNbzda1iPyLjfvQpsUMLR7sGRegYmLsrkY-LQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-01 20:34 ` Paul Bolle
2014-04-01 20:32 ` Grant Likely
[not found] ` <20140401203250.0B2A7C408A6-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-04-01 20:39 ` Grant Likely
2014-04-01 20:46 ` Paul Bolle
[not found] ` <CACxGe6vCrkHPL6UNy1p8AO4+z5VFRY6w4_2grQEZQwp_3jJ7Yw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-26 12:30 ` Linus Walleij
[not found] ` <CACRpkdZoo=P7uTO1rNDD_HUPjfAk26C0=mNYPoZmTV0wcO3V-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-26 14:19 ` Jason Cooper
2014-09-29 8:52 ` Linus Walleij
2014-10-27 15:39 ` Linus Walleij
[not found] ` <CACRpkdYmJWy1_vs0tWRA7SvkQnvbXXKqf7pHpH5b5tZ6vR+KJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-02 20:52 ` [PATCH] ARM: kbuild: Fix forced rebuild after 'make dtbs' Jason Cooper
2014-11-25 21:41 ` Michal Marek [this message]
2014-11-25 23:51 ` Russell King - ARM Linux
[not found] ` <20141125235150.GH3836-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-11-26 0:57 ` Jason Cooper
2014-11-26 13:57 ` Linus Walleij
[not found] ` <CACRpkdZJoWbQeuZ4ZXGbQr0+SNG_9ZA+cQkAA0C2F9rnZDYtyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-26 14:41 ` Russell King - ARM Linux
[not found] ` <20141126144153.GK3836-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-11-28 14:10 ` Linus Walleij
[not found] ` <CACRpkdYwQT3+RLxP_b_kYJoHV4L7sZ7yiU=JZWVq_zHKz0EY_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-01 13:55 ` Michal Marek
[not found] ` <547C7364.8000009-AlSwsSmVLrQ@public.gmane.org>
2014-12-04 11:22 ` Grant Likely
2014-12-04 11:24 ` Russell King - ARM Linux
2014-11-26 9:39 ` Michal Marek
[not found] ` <20140926141943.GC23926-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-09-29 12:49 ` [git pull] Devicetree changes for v3.15 Grant Likely
[not found] ` <20140929124922.CBE9FC4150A-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-09-29 13:52 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5474F78F.2060906@suse.cz \
--to=mmarek@suse.cz \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).