From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version Date: Thu, 01 Sep 2016 15:03:51 +0200 Message-ID: <5477278.USWYFxDPfA@amdc1976> References: <1472648307-3818-1-git-send-email-ayaka@soulik.info> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: In-reply-to: <1472648307-3818-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Randy Li Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Wednesday, August 31, 2016 08:58:27 PM Randy Li wrote: > The TOPEET itop is a samsung exnynos 4412 core board, which have > two package versions. This patch add the support for SCP version. > > Currently supported are USB3503A HSIC, USB OTG, eMMC, rtc and > PMIC. The future features are in the based board. Also MFC and > watchdog have been enabled. > > Signed-off-by: Randy Li > --- > arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi | 490 ++++++++++++++++++++++++ > 1 file changed, 490 insertions(+) > create mode 100644 arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi [...] > + s5m8767_osc: clocks { Don't you also need: compatible = "samsung,s5m8767-clk"; here? BTW Does anyone know why there are no users of "samsung,s2mps11-clk" compatible in the tree (commit 53c31b3437a6400c6ffc2c9315680217ad84cb6d "mfd: sec-core: Add of_compatible strings for clock MFD cells" added it in March 2014)? > + #clock-cells = <1>; > + clock-output-names = "s5m8767_ap", > + "s5m8767_cp", "s5m8767_bt"; > + }; > + > + }; > +}; [...] > +&rtc { > + status = "okay"; > + clocks = <&clock CLK_RTC>, <&s5m8767_osc S2MPS11_CLK_AP>; > + clock-names = "rtc", "rtc_src"; > +}; Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html