From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sai Krishna Musham <sai.krishna.musham@amd.com>,
bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
mani@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, cassel@kernel.org
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@amd.com,
bharat.kumar.gogada@amd.com, thippeswamy.havalige@amd.com
Subject: Re: [PATCH 2/2] PCI: amd-mdb: Add amd,versal2-cpm6-host compatible
Date: Thu, 2 Apr 2026 20:08:08 +0200 [thread overview]
Message-ID: <54786a14-e6eb-48e4-96a3-500a7e9b4de4@kernel.org> (raw)
In-Reply-To: <20260402180006.486229-3-sai.krishna.musham@amd.com>
On 02/04/2026 20:00, Sai Krishna Musham wrote:
> Add "amd,versal2-cpm6-host" to the OF match table of the AMD MDB PCIe
> host controller driver.
>
> The Versal2 CPM6 host controller is DesignWare-based and supports
> PCIe Gen6 operation at up to 64 GT/s per lane. It is currently
> handled by the same driver and match data (NULL) as the existing
> MDB host controller, but CPM6 uses a newer IP revision and differs
> in legacy INTx register offsets.
>
> Use a separate compatible to allow CPM6-specific handling once legacy
> interrupt support is validated.
>
> Signed-off-by: Sai Krishna Musham <sai.krishna.musham@amd.com>
> ---
> drivers/pci/controller/dwc/pcie-amd-mdb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-amd-mdb.c b/drivers/pci/controller/dwc/pcie-amd-mdb.c
> index 3c6e837465bb..325bf7aad657 100644
> --- a/drivers/pci/controller/dwc/pcie-amd-mdb.c
> +++ b/drivers/pci/controller/dwc/pcie-amd-mdb.c
> @@ -511,6 +511,9 @@ static const struct of_device_id amd_mdb_pcie_of_match[] = {
> {
> .compatible = "amd,versal2-mdb-host",
> },
> + {
> + .compatible = "amd,versal2-cpm6-host",
> + },
So devices are fully compatible. Fix your compatibility in the binding
and drop this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-02 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 18:00 [PATCH 0/2] Add support for AMD Versal2 CPM6 host bridge Sai Krishna Musham
2026-04-02 18:00 ` [PATCH 1/2] dt-bindings: PCI: Add compatible " Sai Krishna Musham
2026-04-02 18:07 ` Krzysztof Kozlowski
2026-04-02 18:00 ` [PATCH 2/2] PCI: amd-mdb: Add amd,versal2-cpm6-host compatible Sai Krishna Musham
2026-04-02 18:08 ` Krzysztof Kozlowski [this message]
2026-04-04 3:15 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54786a14-e6eb-48e4-96a3-500a7e9b4de4@kernel.org \
--to=krzk@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=sai.krishna.musham@amd.com \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox