From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v9 3/4] ARM: dts: add RK3288 suspend support Date: Mon, 01 Dec 2014 16:56:13 +0800 Message-ID: <547C2D2D.8050409@rock-chips.com> References: <1416900743-29204-1-git-send-email-zyw@rock-chips.com> <1416900743-29204-4-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Mike Turquette , Ian Campbell , Russell King , Rob Herring , Pawel Moll , Mark Rutland , Linus Walleij , Kevin Hilman , "open list:ARM/Rockchip SoC..." , Tony Xie , Kumar Gala , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 12/01/2014 01:26 PM, Doug Anderson wrote: > Chris, > > On Mon, Nov 24, 2014 at 11:32 PM, Chris Zhong wrote: >> add pmu sram node for suspend, add global_pwroff pinctrl. >> The pmu sram is used to store the resume code. >> global_pwroff is held low level at work, it would be pull to high >> when entering suspend. reference this in the board DTS file since >> some boards need it. >> >> Signed-off-by: Tony Xie >> Signed-off-by: Chris Zhong >> Reviewed-by: Doug Anderson >> Tested-by: Doug Anderson >> >> --- >> >> Changes in v9: None > This is untrue. v8 had more stuff than v9. See: > > https://patchwork.kernel.org/patch/5311621/ > > vs. > > https://patchwork.kernel.org/patch/5372911/ > > I prefer v8. > > > Ah, I missed the ddr pinctrl in V9, Thank you. I have modified it, and post the V10.