* [PATCH 1/1] of-unittest: Deletion of an unnecessary check before the function call "of_node_put" [not found] ` <5317A59D.4@users.sourceforge.net> @ 2014-12-02 13:00 ` SF Markus Elfring [not found] ` <547DB803.1080406-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2016-07-19 20:52 ` [PATCH] of: Delete " SF Markus Elfring 1 sibling, 1 reply; 4+ messages in thread From: SF Markus Elfring @ 2014-12-02 13:00 UTC (permalink / raw) To: Grant Likely, Rob Herring, devicetree; +Cc: LKML, kernel-janitors, Julia Lawall From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 2 Dec 2014 13:54:00 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/of/unittest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index cc0c5ec..06ebe9d 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -486,8 +486,7 @@ static void __init of_selftest_changeset(void) /* Make sure node names are constructed correctly */ selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")), "'%s' not added\n", n21->full_name); - if (np) - of_node_put(np); + of_node_put(np); mutex_lock(&of_mutex); selftest(!of_changeset_revert(&chgset), "revert failed\n"); -- 2.1.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <547DB803.1080406-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>]
* Re: [PATCH 1/1] of-unittest: Deletion of an unnecessary check before the function call "of_node_put" [not found] ` <547DB803.1080406-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> @ 2014-12-03 17:03 ` Grant Likely 0 siblings, 0 replies; 4+ messages in thread From: Grant Likely @ 2014-12-03 17:03 UTC (permalink / raw) To: SF Markus Elfring, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA Cc: LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Julia Lawall On Tue, 02 Dec 2014 14:00:51 +0100 , SF Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> wrote: > From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> > Date: Tue, 2 Dec 2014 13:54:00 +0100 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> Applied, thanks. g. > --- > drivers/of/unittest.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index cc0c5ec..06ebe9d 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -486,8 +486,7 @@ static void __init of_selftest_changeset(void) > /* Make sure node names are constructed correctly */ > selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")), > "'%s' not added\n", n21->full_name); > - if (np) > - of_node_put(np); > + of_node_put(np); > > mutex_lock(&of_mutex); > selftest(!of_changeset_revert(&chgset), "revert failed\n"); > -- > 2.1.3 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] of: Delete an unnecessary check before the function call "of_node_put" [not found] ` <5317A59D.4@users.sourceforge.net> 2014-12-02 13:00 ` [PATCH 1/1] of-unittest: Deletion of an unnecessary check before the function call "of_node_put" SF Markus Elfring @ 2016-07-19 20:52 ` SF Markus Elfring [not found] ` <8db62ad3-2e8a-327e-30a8-594f628cd8be-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 1 sibling, 1 reply; 4+ messages in thread From: SF Markus Elfring @ 2016-07-19 20:52 UTC (permalink / raw) To: devicetree, Frank Rowand, Rob Herring; +Cc: LKML, kernel-janitors, Julia Lawall From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 19 Jul 2016 22:42:22 +0200 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/of/base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index a4b6087..2601167 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1609,8 +1609,7 @@ static int __of_parse_phandle_with_args(const struct device_node *np, */ err: - if (it.node) - of_node_put(it.node); + of_node_put(it.node); return rc; } -- 2.9.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <8db62ad3-2e8a-327e-30a8-594f628cd8be-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>]
* Re: [PATCH] of: Delete an unnecessary check before the function call "of_node_put" [not found] ` <8db62ad3-2e8a-327e-30a8-594f628cd8be-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> @ 2016-08-09 17:35 ` Rob Herring 0 siblings, 0 replies; 4+ messages in thread From: Rob Herring @ 2016-08-09 17:35 UTC (permalink / raw) To: SF Markus Elfring Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Frank Rowand, LKML, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Julia Lawall On Tue, Jul 19, 2016 at 10:52:12PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> > Date: Tue, 19 Jul 2016 22:42:22 +0200 > > The of_node_put() function tests whether its argument is NULL > and then returns immediately. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> > --- > drivers/of/base.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-09 17:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.so urceforge.net>
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-12-02 13:00 ` [PATCH 1/1] of-unittest: Deletion of an unnecessary check before the function call "of_node_put" SF Markus Elfring
[not found] ` <547DB803.1080406-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2014-12-03 17:03 ` Grant Likely
2016-07-19 20:52 ` [PATCH] of: Delete " SF Markus Elfring
[not found] ` <8db62ad3-2e8a-327e-30a8-594f628cd8be-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2016-08-09 17:35 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).