From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path Date: Wed, 03 Dec 2014 11:46:09 -0800 Message-ID: <547F6881.20400@gmail.com> References: <1417110967-16284-1-git-send-email-leif.lindholm@linaro.org> <1417110967-16284-2-git-send-email-leif.lindholm@linaro.org> <547E7455.6090009@gmail.com> Reply-To: frowand.list@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Grant Likely Cc: Leif Lindholm , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , Mark Rutland , Andrew Lunn , "s.hauer@pengutronix.de" , Rob Herring , Ian Campbell , Jean-Christophe PLAGNIOL-VILLARD List-Id: devicetree@vger.kernel.org On 12/3/2014 7:12 AM, Grant Likely wrote: > On Wed, Dec 3, 2014 at 2:24 AM, Frank Rowand wrote: >> On 11/27/2014 9:56 AM, Leif Lindholm wrote: >>> Add a global binding for the chosen node. >>> Include a description of the stdout-path, and an explicit statement on >>> its extra options in the context of a UART console. >>> >>> Opening description stolen from www.devicetree.org, and part of the >>> remaining text provided by Mark Rutland. >>> >>> Signed-off-by: Leif Lindholm >>> --- >>> Documentation/devicetree/bindings/chosen.txt | 42 ++++++++++++++++++++++++++ >>> 1 file changed, 42 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/chosen.txt >>> >>> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt >>> new file mode 100644 >>> index 0000000..9cd74e9 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/chosen.txt >>> @@ -0,0 +1,42 @@ >>> +The chosen node >>> +--------------- >>> + >>> +The chosen node does not represent a real device, but serves as a place >>> +for passing data between firmware and the operating system, like boot >>> +arguments. Data in the chosen node does not represent the hardware. >>> + >>> + >>> +stdout-path property >> >> The code in patch 3/3 adds the extra options feature to the properties: >> >> stdout-path >> linux,stdout-path >> stdout [if (IS_ENABLED(CONFIG_PPC) ... ] > > I don't understand what you mean here. Are you suggesting a change to > this patch? Is there something deficient in it? Assuming that the code change in patch 3 is as desired, then the chosen.txt documentation applies to all three properties, not just stdout-path. So yes, a change is suggested for the documentation. -Frank