devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [kernel PATCH v2 2/2] devicetree: document ARM bindings for QEMU's Firmware Config interface
Date: Fri, 05 Dec 2014 20:04:32 +0100	[thread overview]
Message-ID: <548201C0.1060006@redhat.com> (raw)
In-Reply-To: <CAFEAcA_iY6qxiQO2oGJitZE6QTAwSsdzuF81q=N=Dt4QfjhpHQ@mail.gmail.com>

On 12/05/14 19:57, Peter Maydell wrote:
> On 30 November 2014 at 16:51, Laszlo Ersek <lersek@redhat.com> wrote:
>> +Example:
>> +
>> +/ {
>> +       #size-cells = <0x2>;
>> +       #address-cells = <0x2>;
>> +
>> +       fw-cfg@9020000 {
>> +               compatible = "qemu,fw-cfg-mmio";
>> +               reg = <0x0 0x9020000 0x0 0x1000>;
>> +       };
> 
> I've just noticed that this example claims a register
> region size of 0x1000. This seems wrong, because the
> underlying device doesn't have a register range that
> big. Surely this should be a size of 0x3 ?

Arnd said I should round up the region to 0x1000.

http://thread.gmane.org/gmane.linux.drivers.devicetree/101173/focus=101176

If that's incorrect I'd prefer to post incremental patches, because 4
other series already depend on this kernel docs patch.

Thanks
Laszlo

  reply	other threads:[~2014-12-05 19:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 16:51 [kernel PATCH v2 0/2] devicetree: document ARM bindings for QEMU's Firmware Config interface Laszlo Ersek
     [not found] ` <1417366282-13527-1-git-send-email-lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-30 16:51   ` [kernel PATCH v2 1/2] devicetree: document the "qemu" and "virtio" vendor prefixes Laszlo Ersek
2014-11-30 16:51   ` [kernel PATCH v2 2/2] devicetree: document ARM bindings for QEMU's Firmware Config interface Laszlo Ersek
     [not found]     ` <1417366282-13527-3-git-send-email-lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-12-05 18:57       ` Peter Maydell
2014-12-05 19:04         ` Laszlo Ersek [this message]
     [not found]           ` <548201C0.1060006-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-12-05 19:08             ` Peter Maydell
     [not found]               ` <CAFEAcA8xvJMHKPQOdhH1+RF_MzKQaiqOT3uKF3OhrGSmHkzeRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-10 14:44                 ` Arnd Bergmann
2014-12-04 10:35   ` [kernel PATCH v2 0/2] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548201C0.1060006@redhat.com \
    --to=lersek@redhat.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).