From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 05/19] clk: samsung: exynos5433: Add clocks for CMU_G2D domain Date: Tue, 09 Dec 2014 10:16:20 +0900 Message-ID: <54864D64.4070002@samsung.com> References: <1417510196-6714-1-git-send-email-cw00.choi@samsung.com> <1417510196-6714-6-git-send-email-cw00.choi@samsung.com> <54858D2B.3040809@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <54858D2B.3040809-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pankaj Dubey Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, chanho61.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, geunsik.lim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Pankaj, On 12/08/2014 08:36 PM, Pankaj Dubey wrote: > Hi Chanwoo, > > On Tuesday 02 December 2014 02:19 PM, Chanwoo Choi wrote: >> This patch adds ths mux/divider/gate clocksof CMU_G2D domain which includes > > nit: %s/clocksof/clocks of I'll fix it. > >> G2D/MDMA IPs. The CMU_G2D must need the clocks related to G2D by providing >> CMU_TOP domain. So, this patch add several clocks for G2D from CMU_TOP domain. >> >> Cc: Sylwester Nawrocki >> Cc: Tomasz Figa >> Signed-off-by: Chanwoo Choi >> Acked-by: Inki Dae >> Acked-by: Geunsik Lim >> --- >> .../devicetree/bindings/clock/exynos5433-clock.txt | 8 ++ >> drivers/clk/samsung/clk-exynos5433.c | 144 +++++++++++++++++++++ >> include/dt-bindings/clock/exynos5433.h | 42 +++++- >> 3 files changed, 193 insertions(+), 1 deletion(-) >> > > Verified all changes in clock file against UM I have with me, all changes are OK. > > With small nit in commit message feel free to add: > > Reviewed-by: Pankaj Dubey Thanks for your review. Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html