From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Mikko Perttunen <mperttunen@nvidia.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] ARM: tegra: Add Tegra124 ACTMON support
Date: Tue, 09 Dec 2014 15:13:25 +0100 [thread overview]
Message-ID: <54870385.9060405@collabora.com> (raw)
In-Reply-To: <CAAVeFu+UZyzF6c+MMnXFAKUbDcw6aan13Sg88c9-YbUsbXYKnw@mail.gmail.com>
On 12/09/2014 06:33 AM, Alexandre Courbot wrote:
> On Fri, Dec 5, 2014 at 1:14 AM, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
>> Add device node for the ACTMON block to the Tegra124 device tree.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>>
>> ---
>>
>> v3: * Address misc. style issues found by Thierry and Alexander
>> * Added helpers for register i/o
>> * Further documented the structs
>> * Enable the ACTMON after the IRQ handler has been installed
>> * Disable the ACTMON before removing the IRQ handler
>> * Add governor in a subsys initcall
>>
>> v2: * Add operating-points property
>> ---
>> arch/arm/boot/dts/tegra124.dtsi | 23 +
>> drivers/devfreq/Kconfig | 7 +-
>> drivers/devfreq/Makefile | 2 +-
>> drivers/devfreq/tegra-actmon-devfreq.c | 777 +++++++++++++++++++++++++++++++++
>> drivers/devfreq/tegra-devfreq.c | 718 ------------------------------
>
> In patch 2/3 you create tegra-devfreq.c, to apparently move it to
> tegra-actmon-devfreq.c and (seemingly) add somemore lines to it. This
> makes things difficult to review, and I am almost sure this is a
> naming mistake - could you fix this and resend?
Sorry, I squashed the changes into the wrong commit. Have sent v4 fixing
this.
Cheers,
Tomeu
next prev parent reply other threads:[~2014-12-09 14:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 16:14 [PATCH v3 0/3] Add support for Tegra Activity Monitor Tomeu Vizoso
2014-12-04 16:14 ` [PATCH v3 1/3] of: Add binding for NVIDIA Tegra ACTMON node Tomeu Vizoso
2014-12-04 16:14 ` [PATCH v3 2/3] PM / devfreq: tegra: add devfreq driver for Tegra Activity Monitor Tomeu Vizoso
2014-12-04 16:14 ` [PATCH v3 3/3] ARM: tegra: Add Tegra124 ACTMON support Tomeu Vizoso
[not found] ` <1417709696-29281-4-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-12-09 5:33 ` Alexandre Courbot
2014-12-09 14:13 ` Tomeu Vizoso [this message]
2014-12-09 5:38 ` [PATCH v3 0/3] Add support for Tegra Activity Monitor Alexandre Courbot
2014-12-09 14:14 ` Tomeu Vizoso
[not found] ` <548703C4.1030300-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-12-09 14:18 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54870385.9060405@collabora.com \
--to=tomeu.vizoso@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).